From 4340c22b638bf178ea1257a282fc44d10412ac89 Mon Sep 17 00:00:00 2001 From: Fernando Schauenburg Date: Mon, 30 Jan 2023 08:01:35 +0100 Subject: [PATCH] fix: man_pages on macOS and FreeBSD (#2326) (#2352) macOS 13.x (Ventura, Darwin 22.x) uses `apropos(1)` from FreeBSD, which does not behave the same as the previous implementation up to macOS 12. `apropos(1)` takes a regular expression as an argument, so passing "." causes it to match anything and therefore return all results to be filtered by Telescope. (cherry picked from commit d5f6c0911d6066397f1757c6b55a8bd6851bd6dc) --- lua/telescope/builtin/__internal.lua | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/lua/telescope/builtin/__internal.lua b/lua/telescope/builtin/__internal.lua index 00f220593a..2b074f1de4 100644 --- a/lua/telescope/builtin/__internal.lua +++ b/lua/telescope/builtin/__internal.lua @@ -750,8 +750,16 @@ internal.man_pages = function(opts) opts.sections = vim.F.if_nil(opts.sections, { "1" }) assert(vim.tbl_islist(opts.sections), "sections should be a list") opts.man_cmd = utils.get_lazy_default(opts.man_cmd, function() - local is_darwin = vim.loop.os_uname().sysname == "Darwin" - return is_darwin and { "apropos", " " } or { "apropos", "" } + local uname = vim.loop.os_uname() + local sysname = string.lower(uname.sysname) + if sysname == "darwin" then + local major_version = tonumber(vim.fn.matchlist(uname.release, [[^\(\d\+\)\..*]])[2]) or 0 + return major_version >= 22 and { "apropos", "." } or { "apropos", " " } + elseif sysname == "freebsd" then + return { "apropos", "." } + else + return { "apropos", "" } + end end) opts.entry_maker = opts.entry_maker or make_entry.gen_from_apropos(opts) opts.env = { PATH = vim.env.PATH, MANPATH = vim.env.MANPATH }