Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce MSRV to 1.74.0 #1520

Closed
king-11 opened this issue Jan 21, 2025 · 7 comments · Fixed by #1519
Closed

reduce MSRV to 1.74.0 #1520

king-11 opened this issue Jan 21, 2025 · 7 comments · Fixed by #1519

Comments

@king-11
Copy link
Contributor

king-11 commented Jan 21, 2025

cargo msrv generally returns a version higher that what actually works, I tried running things with 1.74.0 and it worked fine maybe the ci can have an additional rust:1.74.0 based step.

reproduction

sed -i 's/1\.74\.1/1.74.0/g' Cargo.toml
rustup override set 1.74.0
cargo build
cargo test
@king-11 king-11 mentioned this issue Jan 21, 2025
@king-11
Copy link
Contributor Author

king-11 commented Jan 22, 2025

@niklasad1 any thoughts on having an msrv step in ci?

@niklasad1
Copy link
Member

niklasad1 commented Jan 22, 2025

Would be cool to have a MSRV check in the CI, if you are interested to work on that would be great :)

I have only checked it occasionally before publishing new releases i.e, via cargo msrv

@king-11
Copy link
Contributor Author

king-11 commented Jan 22, 2025

Sure I can work on that :)

@king-11
Copy link
Contributor Author

king-11 commented Jan 24, 2025

@niklasad1 is it possible to get an minor release with new MSRV we make use of jsonrpsee in our open source library and aren't able to upgrade it to latest due to MSRV restrictions on our project till 1.74.0 only.

@niklasad1
Copy link
Member

sure

@niklasad1
Copy link
Member

Released v0.24.8 with this fix

@king-11
Copy link
Contributor Author

king-11 commented Jan 24, 2025

Thanks a lot :) appreciate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants