-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing support for AWS Workload Federation #185
Comments
Hey @weaversam8 I've actually gotten this to work with my modifications #184 and #183. I figured it would be a bit much with dependencies to add aws directly (and expect goth to know where to pull in my access creds since we use access tokens in dev environments and roles in production) so I'm dynamically building out the credentials by basically doing this
|
Thanks for the tip @mattmatters! I ended up adding a PR to add AWS support specifically in #186, but your comment helped me track down two issues for my fix! (Both the oddity with URI encoding and the idea to use ExAws to sign the headers came from your comment! ExAws was a huge win because other AWS signature libraries will add the For fetching credentials, I focused on the path that's suggested based on GCP |
❤️ So glad to hear it! That uri oddity had me stumped for a while. |
You know what, funnily enough me too! I just did this implementation for an Erlang project and spent hours fixing the same bug. Wish I had remembered this time 😅 |
Hi there! I tried to set up AWS Workload Federation with
goth
today, and it looks likeGoth.Token.subject_token_from_credential_source/2
is missing a clause for AWS tokens. The current clauses are:but AWS tokens are stored like this in the GCP
credentials.json
format:The text was updated successfully, but these errors were encountered: