Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cookie after dismissing the newsletter popup on the site #6869

Open
nickchomey opened this issue Feb 15, 2025 · 2 comments
Open

Add a cookie after dismissing the newsletter popup on the site #6869

nickchomey opened this issue Feb 15, 2025 · 2 comments

Comments

@nickchomey
Copy link
Contributor

nickchomey commented Feb 15, 2025

Image
This popup keeps coming on every page, no matter how many times I dismiss it on other pages. It is very off-putting.

I suggest that you add cookie so that it doesn't show up after it has been dismissed once.

@pubkey
Copy link
Owner

pubkey commented Feb 17, 2025

We already use localstorage to remember that it was closed for 10 minutes.

@nickchomey
Copy link
Contributor Author

nickchomey commented Feb 18, 2025

Respectfully, that's not really an appropriate way to do this. Once I dismiss it, I should never see it again. Again, it is VERY off-putting - I would not be surprised if some people just write RxDB off completely after getting accosted by the popup a few times.

Looking at the code, I now see that there's 6 different notifications that get randomly chosen. I think it would be better to just put them all in a single floating sidebar widget or something. Perhaps upon each page load, a random one gets selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants