When Second Level Retries are enabled the previous exceptions are swallowed if the handler is not implemented

[arielmoraes]

Our Rebus usage have some default configurations for the developers to follow. One of those configurations is the Second Level Retry as enabled. In newer version of Rebus it's dispatched as soon as the error count reaches the configured limit. As not all messages handlers implementations want to enable second level retries, the IFailed is not implemented on some of them. The problem is the code is swallowing the previous exceptions in case of errors so the error details header will end up with only the MessageCouldNotBeDispatchedToAnyHandlersException error. This is a regression from previous versions.

The problematic line is:

Rebus/Rebus/Retry/Simple/DefaultRetryStep.cs

Line 186 in 3ad15de

await PassToErrorHandler(context, GetAggregateException(new[] { _exceptionInfoFactory.CreateInfo(secondLevelException) }));

Can that be changed to be like:

Rebus/Rebus/Retry/Simple/DefaultRetryStep.cs

Line 193 in 3ad15de

await PassToErrorHandler(context, GetAggregateException(exceptions.Concat(new[] { _exceptionInfoFactory.CreateInfo(secondLevelException), })));

If that is the intended way from now on, is there a way to have Second Level Retries enabled but as a opt-in per message handler?

[arielmoraes]

Adding some information, it seems that every time a fail fast exception should be handled, only the failed fast exception is recorded.