Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove robotpy_extras from pyproject.toml #118

Open
virtuald opened this issue Oct 16, 2024 · 5 comments
Open

Remove robotpy_extras from pyproject.toml #118

virtuald opened this issue Oct 16, 2024 · 5 comments

Comments

@virtuald
Copy link
Member

This is a bit more work than it sounds, need to provide a good alternative mechanism that's easy to update.

@virtuald
Copy link
Member Author

I think we could write a tool to help users add vendors to 'requires'.

A tool could ideally also check for updates, and detect if there were conflicts before offering them to users.

@gerth2
Copy link

gerth2 commented Dec 17, 2024

No major complaint from a user-end, it's trivial to move it over in the toml file. It was always slightly confusing why there were two options.

Inject a comment by default that points at a doc page to how to update the field with common vendor dependencies might be a quick solution to the tool question. I'm not fully visualizing what value the tool has over just manually editing the file, and seeing the errors in robotpy if conflicts are added.

@TheTripleV
Copy link
Member

I'm still a proponent of having a list to install "all". I like having a oneshot command to get everything under the sun

@virtuald
Copy link
Member Author

virtuald commented Jan 4, 2025

I want to get rid of this, but pushing it to 2026.

@virtuald
Copy link
Member Author

virtuald commented Jan 4, 2025

it does occur to me that there is something that robotpy-extras is useful for (but we should rename it to optional_components or something more obvious like that) -- namely, all of the optional wpilib pieces that we don't install by default (cscore, apriltag, etc). That's because they're all robotpy and are correlated together

I think all the vendor stuff should be removed from it and figure out a way to make 'requires' more useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants