Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TestCase methods protected that should have been protected all along #5213

Closed
sebastianbergmann opened this issue Feb 19, 2023 · 2 comments
Assignees
Labels
type/backward-compatibility Something will be/is intentionally broken
Milestone

Comments

@sebastianbergmann
Copy link
Owner

sebastianbergmann commented Feb 19, 2023

  • any() (should also not be static)
  • never() (should also not be static)
  • atLeast() (should also not be static)
  • atLeastOnce() (should also not be static)
  • once() (should also not be static)
  • exactly() (should also not be static)
  • atMost() (should also not be static)
  • returnValue() (should also not be static)
  • returnValueMap() (should also not be static)
  • returnArgument() (should also not be static)
  • returnCallback() (should also not be static)
  • returnSelf() (should also not be static)
  • throwException() (should also not be static)
  • onConsecutiveCalls() (should also not be static)
  • getActualOutputForAssertion()
  • expectOutputRegex()
  • expectOutputString()
  • expectException()
  • expectExceptionCode()
  • expectExceptionMessage()
  • expectExceptionMessageMatches()
  • expectExceptionObject()
  • expectNotToPerformAssertions()
  • getMockBuilder()
@sebastianbergmann sebastianbergmann added the type/backward-compatibility Something will be/is intentionally broken label Feb 19, 2023
@sebastianbergmann sebastianbergmann added this to the PHPUnit 11.0 milestone Feb 19, 2023
@sebastianbergmann sebastianbergmann self-assigned this Feb 19, 2023
@sebastianbergmann sebastianbergmann changed the title Make TestCase methods protected that should have been protected all along Make TestCase methods protected that should have been protected all along Mar 6, 2023
@InvisibleSmiley
Copy link

The fact that some of the methods are not static anymore did not make it to the changelog.

It's not a big deal (I don't mind the change) but I wonder what the reasoning behind that was. Seems random to me. Care to explain?

@allentje
Copy link

The fact that some of the methods are not static anymore did not make it to the changelog.

It's not a big deal (I don't mind the change) but I wonder what the reasoning behind that was. Seems random to me. Care to explain?

I agree. It would have been great to have had these changes referenced in the changelog for more awareness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/backward-compatibility Something will be/is intentionally broken
Projects
None yet
Development

No branches or pull requests

3 participants