Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some themes fail to find media.3d categories in vivid 0.10 #136

Closed
tranzystorekk opened this issue Jun 22, 2024 · 5 comments · Fixed by #137
Closed

Some themes fail to find media.3d categories in vivid 0.10 #136

tranzystorekk opened this issue Jun 22, 2024 · 5 comments · Fixed by #137

Comments

@tranzystorekk
Copy link

Environment details:

OS: Void Linux on WSL2
Shell: zsh 5.9
Terminal: wezterm 20240520-135708-b8f94c47 x86_64-pc-windows-msvc

Tested with a simple script:

$ for theme in $(vivid themes); do if ! vivid generate ${theme} > /dev/null; then echo "${theme} failed!"; fi; done
Error: Could not find style for category 'media.3d.mesh'
dracula failed!
Error: Could not find style for category 'media.3d.mesh'
lava failed!
Error: Could not find style for category 'media.3d.mesh'
modus-operandi failed!
Error: Could not find style for category 'media.3d.mesh'
nord failed!
Error: Could not find style for category 'media.3d.application'
solarized-dark failed!
Error: Could not find style for category 'media.3d.application'
solarized-light failed!
Error: Could not find style for category 'media.3d.mesh'
tokyonight-moon failed!
Error: Could not find style for category 'media.3d.application'
tokyonight-night failed!
Error: Could not find style for category 'media.3d.application'
tokyonight-storm failed!
@sharkdp
Copy link
Owner

sharkdp commented Jun 22, 2024

Oh — thank you for reporting that! I thought we had tests for those kind of basic checks. Should have been more careful when creating the release. Should be easy to fix hopefully.

@sharkdp
Copy link
Owner

sharkdp commented Jun 22, 2024

Fixed; new release is out. Thanks again

@zmargeta
Copy link

zmargeta commented Jun 25, 2024

Hi @sharkdp, this issue is unfortunately still reproducible on 0.10.1.

I am using fish shell and tokyonight-storm theme, and still randomly get either

Error: Could not find style for category 'media.3d.mesh'
Error: Could not find style for category 'media.3d.application'

@sharkdp
Copy link
Owner

sharkdp commented Jun 27, 2024

Do you happen to have an old theme file lying around on your disk?

@zmargeta
Copy link

zmargeta commented Jul 1, 2024

@sharkdp you are correct, it got left over on disk :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants