Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The gitmodified filter will infinitely loop when encountering deleted file paths #2393

Merged
merged 1 commit into from
Jan 30, 2019
Merged

The gitmodified filter will infinitely loop when encountering deleted file paths #2393

merged 1 commit into from
Jan 30, 2019

Conversation

lmanzke
Copy link
Contributor

@lmanzke lmanzke commented Jan 29, 2019

Deleted files cause realpath($path) to return false. When this value
enters the while loop, it will run indefinitely as the condition will
never be matched.

@lmanzke
Skip deleted files when filtering for git-modified
c112065 
Deleted files cause realpath($path) to return false. When this value
enters the while loop, it will run indefinitely as the condition will
never be matched.
jrfnl
jrfnl approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@jrfnl jrfnl mentioned this pull request Jan 29, 2019
Merged
@gsherwood gsherwood added this to the 3.4.1 milestone Jan 30, 2019
@gsherwood gsherwood changed the title Skip deleted files when filtering for git-modified The gitmodified filter will infinitely loop when encountering deleted file paths Jan 30, 2019
@gsherwood gsherwood merged commit c112065 into squizlabs:master Jan 30, 2019
gsherwood added a commit that referenced this pull request Jan 30, 2019
@gsherwood
Changelog for #2393
3dd9e97
@gsherwood
Copy link
Member

Thanks a lot for finding and fixing this.

@lmanzke
Copy link
Contributor Author

lmanzke commented Jan 30, 2019

You're welcome :)

@lmanzke lmanzke deleted the bugfix/infinite-modified-loop branch January 30, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrfnl jrfnl jrfnl approved these changes

Assignees
No one assigned
Labels
Type: bug
Projects
None yet
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@lmanzke @gsherwood @jrfnl