Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] skip-* icon names/svgs are mixed up, and also have hardcoded stroke color of black #84

Closed
tmorehouse opened this issue Dec 14, 2019 · 1 comment · Fixed by #138

Comments

@tmorehouse
Copy link

tmorehouse commented Dec 14, 2019

The skip-* Icons are slightly mixed up name-wise:

image

Also, the skip-*-fill SVGs have a hardcoded stroke color or #000 which always shows as black, regardless of current font color. Perhaps this should be currentColor instead of #000 (or set stroke="currentColor" on the <svg> root element.

<svg class="bi bi-skip-end-fill" width="1em" height="1em" viewBox="0 0 20 20" fill="currentColor" xmlns="http://www.w3.org/2000/svg">
  <!-- this shoud be `currentColor` not `#000` -->
  <path stroke="#000" stroke-linecap="round" d="M2.5 6v8"/>
  <path d="M2.904 10.697l6.363 3.692c.54.313 1.233-.066 1.233-.697V6.308c0-.63-.693-1.01-1.233-.696L2.904 9.304a.802.802 0 000 1.393z"/>
  <path d="M10.404 10.697l6.363 3.692c.54.313 1.233-.066 1.233-.697V6.308c0-.63-.692-1.01-1.233-.696l-6.363 3.692a.802.802 0 000 1.393z"/>
</svg>

cc/ @mdo

@tmorehouse tmorehouse changed the title Skip icon names are mixed up plus hardcoded black stroke [bug] skip icon names/svgs are mixed up and also have hardcoded stroke color of black Dec 15, 2019
@tmorehouse
Copy link
Author

Related issue: text-right also appears to have a stroke color of #000.

@tmorehouse tmorehouse changed the title [bug] skip icon names/svgs are mixed up and also have hardcoded stroke color of black [bug] skip-* icon names/svgs are mixed up, and also have hardcoded stroke color of black Dec 16, 2019
@mdo mdo mentioned this issue Mar 8, 2020
@mdo mdo closed this as completed in #138 Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant