From 9e26774cef9bf37d3e8cb69c9fd794467eb346c9 Mon Sep 17 00:00:00 2001 From: Jeremy Jay Date: Wed, 1 Jan 2025 22:36:05 -0500 Subject: [PATCH] found a place it mattered, pushing the star replacement to the generate side --- v2/internal/binding/generate.go | 1 + v2/internal/binding/reflect.go | 2 +- v2/internal/typescriptify/typescriptify.go | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/v2/internal/binding/generate.go b/v2/internal/binding/generate.go index f1a15900079..de07f8022f6 100644 --- a/v2/internal/binding/generate.go +++ b/v2/internal/binding/generate.go @@ -229,6 +229,7 @@ var ( func goTypeToTypescriptType(input string, importNamespaces *slicer.StringSlicer) string { tname := goTypeToJSDocType(input, importNamespaces) + tname = strings.ReplaceAll(tname, "*", "") gidx := strings.IndexRune(tname, '[') if gidx > 0 { // its a generic type rem := strings.SplitN(tname, "[", 2) diff --git a/v2/internal/binding/reflect.go b/v2/internal/binding/reflect.go index 57a6335bd5b..d293a743aa2 100644 --- a/v2/internal/binding/reflect.go +++ b/v2/internal/binding/reflect.go @@ -166,7 +166,7 @@ func getPackageName(in string) string { } func getSplitReturn(in string) (string, string) { - result := strings.Split(in, ".") + result := strings.SplitN(in, ".", 2) return result[0], result[1] } diff --git a/v2/internal/typescriptify/typescriptify.go b/v2/internal/typescriptify/typescriptify.go index c5bfe74cbe0..5ef61449caf 100644 --- a/v2/internal/typescriptify/typescriptify.go +++ b/v2/internal/typescriptify/typescriptify.go @@ -955,7 +955,7 @@ func indentLines(str string, i int) string { func getStructFQN(in string) string { result := strings.ReplaceAll(in, "[]", "") - //result = strings.ReplaceAll(result, "*", "") + result = strings.ReplaceAll(result, "*", "") return result }