Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Terminal incorrectly render command line when command is longer than the widget width #1898

Open
3 tasks
nicholaslck opened this issue Feb 4, 2025 · 2 comments
Labels
bug Something isn't working triage Needs triage

Comments

@nicholaslck
Copy link

Current Behavior

The input will suddenly being masked and the PS1 prompt will gone (e.g. path to home "~" is gone )

Expected Behavior

The input line should not be overwrite and keep allowing user to type in the next line.

Steps To Reproduce

  1. Open a terminal widget
  2. Keep typing "a" until the line is longer than the widget window width

Wave Version

v0.11.0

Platform

macOS

OS Version/Distribution

Sequoia 15.3

Architecture

arm64

Anything else?

I am using zsh with zap-zsh/zap-prompt

Questionnaire

  • I'm interested in fixing this myself but don't know where to start
  • I would like to fix and I have a solution
  • I don't have time to fix this right now, but maybe later
@nicholaslck nicholaslck added bug Something isn't working triage Needs triage labels Feb 4, 2025
@nicholaslck
Copy link
Author

Screen.Recording.2025-02-04.at.10.55.06.AM.mov

scenario of the bug

@sawka
Copy link
Member

sawka commented Feb 19, 2025

I tested locally and I'm not seeing this behavior, but I can think of a couple reasons why things might not be working:

if you make the terminal a bit smaller (so it is easy to count). can you run stty size which will show [rows] [cols]. and then re-do your test and we can count the number of columns that actually appear on the screen. we should be able to see if they match up?

i have a pending PR to fix the "out of order" window size updates (although i haven't actually seen this problem come up in the real world).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Needs triage
Projects
None yet
Development

No branches or pull requests

2 participants