Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for CJK characters in the description #424

Open
wei opened this issue Dec 12, 2024 · 4 comments
Open

Add tests for CJK characters in the description #424

wei opened this issue Dec 12, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@wei
Copy link
Owner

wei commented Dec 12, 2024

We've encountered an issue in the past with CJK characters #227 #156 #157, let's add some more tests for cards with Chinese / Japanese / Korean characters.

Now possible all thanks to the addition of Playwright e2e testing by @KemingHe.

@wei wei added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Dec 12, 2024
@KemingHe
Copy link
Collaborator

I can expand on the simpleUserStory.spec.ts to include foreign char input. Let me know whether to put this in front or behind upgraded to NextJS 15.

@wei
Copy link
Owner Author

wei commented Dec 12, 2024

Next15 first 😄

@KemingHe
Copy link
Collaborator

Hi @wei , now that the Next15 upgrade is finished, I'll be happy to start on this one.

What's the easiest why to replicate the bug(s)?

@wei
Copy link
Owner Author

wei commented Dec 21, 2024

Cool beans! The bugs have been fixed in the issues linked.

For this task we can add a custom description that contain Chinese, Japanese, Korean characters and take a snapshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants