Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File panel doesn't auto updates. #599

Open
lazysegtree opened this issue Feb 8, 2025 · 3 comments
Open

File panel doesn't auto updates. #599

lazysegtree opened this issue Feb 8, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@lazysegtree
Copy link
Collaborator

Describe the bug
When you delete a file, file panel usually doesn't automatically updates itself unless you press a button

To Reproduce
Steps to reproduce the behavior:

  1. Create a new file
  2. Delete the file.
  3. You will see that file would still be visible in panel
  4. Press any other key to force refresh and then file would be removed

Expected behavior
As soon as delete finishes, file should automatically be removed

Screenshots
If applicable, add screenshots to help explain your problem.

Image Image
spf_file_refresh_issue.mp4

System information (please complete the following information):

  • OS: MacOS
  • Version 14
  • superfile Version 1.1.7.1
@lazysegtree lazysegtree added the bug Something isn't working label Feb 8, 2025
@BhagatHarsh
Copy link
Contributor

It is working fine on windows 10.

Could this be because we are moving the file to trash which is not taking more then 3 seconds causing the system to skip rerender?

In model.go

Image

@lazysegtree
Copy link
Collaborator Author

lazysegtree commented Feb 8, 2025

@BhagatHarsh Yeah. I think the code snippet you shared is the reason.
It should not work in windows as well, for the same reason of non re rendering twice within 3 seconds, I will try to see if I can reproduce it in windows.

But, I think this is a laggy User Experience. We should force re-render in case of file operations.

cc : @yorukot

@lazysegtree
Copy link
Collaborator Author

@BhagatHarsh Very strange that this doesn't happens on windows. I tried a lot of delete operations but couldn't reproduce it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants