Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the go report. #626

Open
lazysegtree opened this issue Feb 19, 2025 · 3 comments
Open

Fix the go report. #626

lazysegtree opened this issue Feb 19, 2025 · 3 comments
Labels
pending release Fix is merged, but not released to the newer version
Milestone

Comments

@lazysegtree
Copy link
Collaborator

lazysegtree commented Feb 19, 2025

Go report of the code says "B" as per website

Image

while locally running it says A+

Details

➜  ~/Workspace/kuknitin/superfile git:(main) [10:07:22]  goreportcard-cli -v
Grade ........... A+ 97.1%
Files ................. 33
Issues ................. 8
gofmt ............... 100%
go_vet .............. 100%
gocyclo .............. 75%
	src/internal/config_function.go
		Line 246: warning: cyclomatic complexity 16 of function LoadAllDefaultConfig() is high (> 15) (gocyclo)
	src/internal/handle_file_operations.go
		Line 401: warning: cyclomatic complexity 16 of function (*model).pasteItem() is high (> 15) (gocyclo)
	src/internal/key_function.go
		Line 17: warning: cyclomatic complexity 35 of function (*model).mainKey() is high (> 15) (gocyclo)
		Line 139: warning: cyclomatic complexity 23 of function (*model).normalAndBrowserModeKey() is high (> 15) (gocyclo)
	src/internal/model_render.go
		Line 79: warning: cyclomatic complexity 29 of function (*model).filePanelRender() is high (> 15) (gocyclo)
		Line 587: warning: cyclomatic complexity 28 of function (*model).filePreviewPanelRender() is high (> 15) (gocyclo)
		Line 458: warning: cyclomatic complexity 22 of function (*model).helpMenuRender() is high (> 15) (gocyclo)
		Line 195: warning: cyclomatic complexity 18 of function (*model).processBarRender() is high (> 15) (gocyclo)
	src/internal/file_operations.go
		Line 163: warning: cyclomatic complexity 21 of function pasteDir() is high (> 15) (gocyclo)
	src/internal/file_operations_extract.go
		Line 87: warning: cyclomatic complexity 20 of function unzip() is high (> 15) (gocyclo)
	src/internal/function.go
		Line 279: warning: cyclomatic complexity 20 of function (*model).returnMetaData() is high (> 15) (gocyclo)
		Line 45: warning: cyclomatic complexity 16 of function returnDirElement() is high (> 15) (gocyclo)
	src/internal/handle_panel_movement.go
		Line 410: warning: cyclomatic complexity 18 of function (*model).controlSideBarListUp() is high (> 15) (gocyclo)
		Line 478: warning: cyclomatic complexity 17 of function (*model).controlSideBarListDown() is high (> 15) (gocyclo)
ineffassign ......... 100%
license ............. 100%
misspell ............ 100%
➜  ~/Workspace/kuknitin/superfile git:(main) [10:07:35]

I dont know what is going on, but this "B" doesn't look good.

Can someone dig into this and get it fixed ?

@lazysegtree lazysegtree added the good first issue Good for newcomers label Feb 19, 2025
@jachewz
Copy link
Contributor

jachewz commented Feb 20, 2025

The goreportcard website uses the latest tagged released version of the repo which is 1.1.7 -

Image

The website gets the version of the repo needed from here: https://proxy.golang.org/github.com/yorukot/superfile/@latest

Your local run seems to be on the main branch which has a formatting PR after the 1.1.7 release: #600

Easiest fix is probably to create a new release after #600's merge commit.

@lazysegtree
Copy link
Collaborator Author

Thanks @jachewz Makes sense now.

We are in the middle of a new release, but we are doing some testing first to make sure new changes doesn't break anything and are stable.

@lazysegtree
Copy link
Collaborator Author

Will close this issue when the release is done

@lazysegtree lazysegtree removed the good first issue Good for newcomers label Feb 20, 2025
@lazysegtree lazysegtree added this to the Release 1.2.0 milestone Feb 20, 2025
@lazysegtree lazysegtree added the pending release Fix is merged, but not released to the newer version label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending release Fix is merged, but not released to the newer version
Projects
None yet
Development

No branches or pull requests

2 participants