Add a systray applet #149
Add a systray applet #149
Conversation
|
A note: If we want to pick sides (most likely for the sake of simplicity) between the toolkits, this could be cut down noticably. I simply wanted to try my hand at making it as available as I could. |
|
Just some quick comments after a first read:
Uh... Too bad :(
Is there a specific reason to launch it via the
"Defaults to
Fair enough 🤣
Alright, no problem. Should be able to test that in a minimal environment to make sure nothing's missing :)
Well, I'm in a favor of making this as simple as possible (at least to start things of), ideally both in terms of dependencies and about the python script itself (also for maintenance reasons. While the script looks fairly simple and intelligible, I'm definitely not as comfortable with Python than I am with bash 😅). So I'm all in favor of picking a side on that front. Usually I would personally choose GTK over QT for some reasons, but if the "menu quirk" cannot be fixed or worked around, I'm afraid that's a non-starter :/ Once again, thank you so much for your incredible work on this! 🙏 |
|
I also saw you made |
It nets your the users preferred terminal. Running it directly will be unhelpful as it'll get no terminal, and we could take guesses at which terminal installed the user would prefer. The launchers used will do it in a more sensible way than I could manage in a handful of lines of code |
You're welcome to! I always use them locally because it's a huge burden off me to be able to auto-format python. |
Oh yeah right, good catch! |
Yeah, this is a huge problem for me. From everything I'm reading AppIndicator is dropped entirely in Gtk4, and they put as much effort into breaking it as possible before that happened too. I keep thinking there should be a toolkit-agnostic way to do this, but I've not found it yet |
Well, I guess that coincides with the fact that Gnome wants to get rid of systrays altogether :P I guess this is also an additional legit reason to go with QT?
Hopefully there is, maybe we'll find one at some point ^^ |
|
I added pylint to CI. Do you mind checking the output to see what can be addressed (or eventually ignored if needed)? I assume that picking a side regarding the toolkit will allow to remove some parts of the code. Regarding the apparent GTK position regarding AppIndicator, I guess the safe choice is to go with QT6. |
- - Doing so successfully would require we use python pip for our packaging, which is a problem for another day - Some minor alterations for pylint
|
My opinion is this is one for "we don't care"... the import ones we couldn't get around without switching the project to using pip or some other python-first build system, but this one is "we want your file to use underscores and not minus" ... which I don' think matters here as this isn't a module to begin with |
Yeah fair enough, sounds good to me. 👍 Thanks! |
|
Do we want it stripped of GTK before going ahead? It brings the least with it and has the higher bar for requirements |
|
Well, I was about to ask your opinion about going with python-pyqt6 + glib2 but it seems your mind is set 🙂 |
|
Oh out of AppIndicator3 and QSystemTrayIcon there's a clear winner. A bit confusing choosing glib2 and pyqt6 but... kioclient automatically assumes konsole in my case. It'll make requirements page much simpler than trying everything-and-kitchen-sink. |
|
Something I didn't mention earlier... Python pulls in the gettext translations set by the rest of this package, but never ends up using it in any meaningful way. For now I'll remove it again, but it's always an option to have menus etc with translated text |
- Remove exo open - Remove kioclient - Remove gettext
Why is that? To give you my train of thoughts: pyqt6 is the only option listed to go with the QT6 toolkit. As for glib2, it has the advantage of being a dependency for a lot of packages, meaning it is probably already installed on basically every people's system. But am I missing something?
I don't mind QT but I'd like to avoid KDE stuff if possible. I'm genuinely triggered by such "assumptions" as you described above as well as the
That's the aim here. Keep it simple as they say :) |
Alright, thanks for info. I don't intend to add any kind of menu for now so it's fine dropping it. |
|
Alright, I think we're good for the systray applet itself, everything seems to work as intended. 🥳 I'll proceed with the remaining parts listed here as soon as possible. Once done, and after an additional round of extended tests (just for good measures), we can merge this PR! 😄 I should have the new icons set merged by then so we will hopefully be able to cut the |
|
Looks good! Glad we found the rest of the dependencies, I had a feeling something else was needed |
|
@trigg Hey! Can you sync/update your fork so I can cherry-pick the new icons set into that PR please? :) I'm trying to get this merged today \o/ |
|
Done that now |
|
Thx! |
|
@trigg Some updated icons have been merged in the main branch. Are you available to re-sync your fork? 🙏 |
There was a problem hiding this comment.
It took quite some time but I finally adapted documentation, added the few remaining specs and ran tests. I can finally say it: LGTM!
One last time, thanks for your incredible work and help on this.
I'll tag a new release shortly. Let's ship this applet to people! 🚀
src/script/arch-update-tray.py/usr/bin/arch-update-trayby default.desktopfile, so glib dependency is required to launch itDependencies
python3python-pyqt6qt6-svgglib2qt6-wayland(for people running Wayland)Closes #146