Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQ] TLS support in Spring Boot with Azure Key Vault Certificates #28243

Open
2 tasks done
saragluna opened this issue Apr 12, 2022 · 8 comments · May be fixed by #44259
Open
2 tasks done

[FEATURE REQ] TLS support in Spring Boot with Azure Key Vault Certificates #28243

saragluna opened this issue Apr 12, 2022 · 8 comments · May be fixed by #44259
Assignees
@moarychan
Labels
azure-spring All azure-spring related issues azure-spring-jca azure-spring-keyvault Spring keyvault related issues. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone
2025-03

Comments

@saragluna
Copy link
Member

saragluna commented Apr 12, 2022 •
edited by stliu
Loading

Is your feature request related to a problem? Please describe.
Spring web applications can either be an HTTP client or an HTTP server, if an application wants to secure the HTTP communication via TLS and the certificates are stored in Azure Key Vault, spring-cloud-azure-starter-keyvault-certificates should support it.

  • If one-way TLS is used:
    • In the case of an HTTP server, users shall be able to configure the server's certificates in Azure Key Vault.
    • In the case of an HTTP client, users shall be able to validate the server's certificates stored in Azure Key Vault.
  • If two-way TLS is used:
    • In the case of an HTTP server:
      • Users shall be able to configure the server's certificates in Azure Key Vault.
      • Users shall be able to validate the client certificates in Azure Key Vault.
    • In the case of an HTTP client:
      • Users shall be able to configure the client's certificates stored in Azure Key Vault to the server.
      • Users shall be able to validate the server's certificates stored in Azure Key Vault.

Given Spring MVC or WebFlux is used, the below scenarios should be supported:

  • As a web server, users shall be able to use this feature with Spring MVC with Tomcat, Jetty, and Undertow.
  • As a web server, users shall be able to use this feature with Spring WebFlux with Netty。
  • As a web client, users shall be able to use this feature with Spring MVC and RestTemplate.
  • As a web client, users shall be able to use this feature with Spring WebFlux and Web Client.

Additional context
N/A

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Description Added
  • Expected solution specified
@saragluna saragluna added Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. azure-spring All azure-spring related issues azure-spring-keyvault Spring keyvault related issues. labels Apr 12, 2022
@saragluna saragluna added this to the Backlog milestone Apr 12, 2022
@saragluna saragluna moved this to Todo in Spring Cloud Azure Apr 12, 2022
@saragluna saragluna mentioned this issue Apr 12, 2022
Closed
2 tasks
@saragluna saragluna self-assigned this Apr 28, 2022
@chenrujun chenrujun mentioned this issue May 7, 2022
Closed
@saragluna
Copy link
Member Author

https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.7-Release-Notes#web-server-ssl-configuration-using-pem-encoded-certificates

@moarychan moarychan mentioned this issue Aug 25, 2022
Merged
@saragluna saragluna removed their assignment Dec 5, 2022
@saragluna saragluna mentioned this issue Dec 12, 2022
Closed
2 tasks
@stliu stliu changed the title [FEATURE REQ] Support TLS with certificates stored in Azure Key Vault in spring-cloud-azure-starter-keyvault-certificates [FEATURE REQ] TLS support in Spring Boot with Azure Key Vault Certifiactes Dec 13, 2022
@stliu stliu changed the title [FEATURE REQ] TLS support in Spring Boot with Azure Key Vault Certifiactes [FEATURE REQ] TLS support in Spring Boot with Azure Key Vault Certificates Dec 13, 2022
@stliu
Copy link
Member

stliu commented Dec 30, 2022

#25880 the sample should be updated as well

@stliu stliu mentioned this issue Dec 30, 2022
Closed
@saragluna saragluna modified the milestones: Backlog, 2023-03 Dec 30, 2022
This was referenced Jan 17, 2023
Closed
Closed
@backwind1233
Copy link
Contributor

Link to user issue: #32854

@rvervaek
Copy link

We require this feature too in spring-azure libs 4.x+ and 5.x+. We are stuck using the old 3.x libraries because of this.

@moarychan
Copy link
Member

Hi @rvervaek , thanks for using our library!
We have received your submission and will take it into consideration and will keep you updated on the progress of our review.

@gzmrst-sr
Copy link

Is this ever planned to happen? We would very much like to be able to upgrade to a newer version of this library

@saragluna
Copy link
Member Author

@gzmrst-sr please help vote this feature request. BTW, are you using the jca starter now?

@github-actions GitHub Actions
Copy link
Contributor

Hi @saragluna, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 12, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Spring Cloud Azure Apr 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
@rujche rujche reopened this Jul 31, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Spring Cloud Azure Jul 31, 2024
@rujche rujche modified the milestones: 2023-03, Backlog Jul 31, 2024
@saragluna saragluna modified the milestones: Backlog, 2025-01 Nov 29, 2024
@saragluna saragluna modified the milestones: 2025-01, 2025-02 Dec 16, 2024
@saragluna saragluna modified the milestones: 2025-02, 2025-03 Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@moarychan moarychan

Labels
azure-spring All azure-spring related issues azure-spring-jca azure-spring-keyvault Spring keyvault related issues. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
Spring Cloud Azure
Status: In Progress
Milestone
2025-03
Development

Successfully merging a pull request may close this issue.

Support Spring SSL bundles based on Key Vault JCA moarychan/azure-sdk-for-java
7 participants
@stliu @backwind1233 @moarychan @rvervaek @saragluna @gzmrst-sr @rujche