Support Spring SSL bundles based on Key Vault JCA #44259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
moarychan
requested review from
rujche,
Netyyyy and
saragluna
as code owners
saragluna
requested changes
Feb 19, 2025
| return; | ||
| } | ||
|
|
||
| final AtomicBoolean providerConfigured = new AtomicBoolean(false); |
There was a problem hiding this comment.
why does this need to be an atomic? Seems like there's no concurrency issue?
There was a problem hiding this comment.
Since here need a final variable
| return; | ||
| } | ||
|
|
||
| configureJcaSystemProperties(bundleProperties); |
There was a problem hiding this comment.
Should we unset the system properties later?
There was a problem hiding this comment.
Will update the logic when JCA changed.
...d/autoconfigure/implementation/keyvault/jca/properties/AzureKeyVaultSslBundleProperties.java
Outdated
Show resolved
Hide resolved
...ure-autoconfigure/src/main/resources/azure-security-keyvault-jca-user-agent-value-prefix.txt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #28243, #35782
Support Spring SSL bundles based on Key Vault JCA, the new starter
spring-cloud-azure-starter-keyvault-jcais compatible with Spring Boot 3.1+.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines