STG98 - NFS over REST #44268
STG98 - NFS over REST #44268
Conversation
gunjansingh-msft
requested review from
ibrahimrabab,
seanmcc-msft,
ibrandes,
kyleknap and
alzimmermsft
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
| */ | ||
| public Mono<Response<ShareFileSymbolicLinkInfo>> getSymbolicLinkWithResponse() { | ||
| try { | ||
| return withContext(context -> getSymbolicLinkWithResponse(context)); |
There was a problem hiding this comment.
this can be replaced with a lambda expression, return withContext(this::getSymbolicLinkWithResponse);
| ShareRequestConditions requestConditions, Context context) { | ||
| context = context == null ? Context.NONE : context; | ||
| return this.azureFileStorageClient.getFiles() | ||
| .createSymbolicLinkWithResponseAsync(shareName, filePath, linkText, null, null, null, null, null, |
There was a problem hiding this comment.
we want to make sure to pass in our options here, so we will have to change the signature to accommodate this. specifically, we need to make sure we pass in metadata, fileCreationTime, fileLastWriteTime, owner, and group.
There was a problem hiding this comment.
also, fileCreationTime and fileLastWriteTime are OffsetDateTime in our options bag, but they need to be a string to be passed into the implementation method. you can use this util method to convert it:
String fileCreationTimeString = FileSmbProperties.parseFileSMBDate(fileCreationTime);
| Mono<Response<ShareFileSymbolicLinkInfo>> getSymbolicLinkWithResponse(Context context) { | ||
| context = context == null ? Context.NONE : context; | ||
| return this.azureFileStorageClient.getFiles() | ||
| .getSymbolicLinkWithResponseAsync(shareName, filePath, null, null, null, context) |
There was a problem hiding this comment.
we want to make sure to pass in the snapshot here:
.getSymbolicLinkWithResponseAsync(shareName, filePath, null, snapshot, null, context)
|
|
||
| Mono<Response<ShareFileInfo>> createSymbolicLinkWithResponse(String linkText, | ||
| ShareRequestConditions requestConditions, Context context) { | ||
| context = context == null ? Context.NONE : context; |
There was a problem hiding this comment.
we should also add a null check for requestConditions, as if it is null and we call requestConditions.getLeaseId() it will throw an error.
requestConditions = requestConditions == null ? new ShareRequestConditions() : requestConditions;
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines