STG98 - x-ms-file-request-intent support for blob copy #44269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunjansingh-msft
requested review from
ibrahimrabab,
seanmcc-msft,
ibrandes,
kyleknap and
alzimmermsft
as code owners
ibrandes
changed the title
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
ibrandes
reviewed
Feb 19, 2025
| @@ -142,4 +144,24 @@ public AppendBlobAppendBlockFromUrlOptions setSourceAuthorization(HttpAuthorizat | |||
| this.sourceAuthorization = sourceAuthorization; | |||
| return this; | |||
| } | |||
|
|
|||
| /** | |||
| * Gets the sourceShareTokenIntent for the file share. | |||
There was a problem hiding this comment.
For getters and setters in all options, lets change this comment to:
"Optional, only applicable (but required) when the source is Azure Storage Files and using token authentication.
Gets/Sets the intent of the request."
(using gets or sets relative to if the comment is for a getter or setter)
We should also link to the FileShareTokenIntent class anytime we mention it in the return line {@link FileShareTokenIntent}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines