Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web-pubsub-client] Migrate to core-websockets #33106

Open
wants to merge 4 commits into
base: feat/websockets
Choose a base branch
from

Conversation

deyaaeldeen
Copy link
Member

@deyaaeldeen deyaaeldeen commented Feb 18, 2025

Packages impacted by this PR

@azure/web-pubsub-client

Issues associated with this PR

N/A

Describe the problem that is addressed by this PR

Migrates the Azure Web PubSub client to depend on the newly introduced @azure/core-websockets maintaining the current client behavior. In addition, this PR adds the following to facilitate testing:

  • a simulator for the Azure Web PubSub WebSocket service.
  • a toxic WebSocket proxy that can drop the connection and messages according to the drop probability

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

N/A

Are there test cases added in this PR? (If not, why?)

Yes!

Provide a list of related PRs (if any)

#32555

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant