Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/client side encryption and query-pipeline #33142

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

aditishree1
Copy link
Member

@aditishree1 aditishree1 commented Feb 20, 2025

Packages impacted by this PR

@azure/cosmos

Issues associated with this PR

N/A

Describe the problem that is addressed by this PR

This PR

  • fixes the copyObject method for encryption and handles 'undefined' and 'bigint' type.
  • modifies initializeEncryption to ensure cache get warms up with encryption only one time.
  • fixes the semaphore.leave error in query pipeline
  • adds diagnostics to all the properties and operations encrypted/decrypted except encrypting query params

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 20, 2025

API change check

APIView has identified API level changes in this PR and created following API reviews.

@azure/cosmos

@aditishree1 aditishree1 changed the title Fix/client side encryption Fix/client side encryption and query-pipeline Feb 20, 2025
@aditishree1 aditishree1 marked this pull request as ready for review February 20, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants