Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure App Configuration - Advertise @azure/configuration-provider in README #33152

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zhiyuanliang-ms
Copy link

Packages impacted by this PR

@azure/app-configuration

@github-actions github-actions bot added the App Configuration Azure.ApplicationModel.Configuration label Feb 21, 2025
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@@ -1,13 +1,28 @@
# App Configuration client library for JavaScript
# Azure App Configuration SDK for JavaScript
Copy link
Member

@HarshaNalluru HarshaNalluru Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Azure App Configuration SDK for JavaScript
# Azure App Configuration client library for JavaScript

This according to the guidelines.
But, @jeremymeng @xirzec thoughts?

Guidelines: https://github.com/Azure/azure-sdk/blob/main/docs/typescript/refs.md
Template example: https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/template/template#readme

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why we would change the title as this is the README for @azure/app-configuration, not a general doc for SDK related to app configuration.

Copy link
Author

@zhiyuanliang-ms zhiyuanliang-ms Feb 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to distinguish it with @azure/app-configuration-provider. But I am ok with the original title.

This library @azure/app-configuration is developed by Azure SDK team. The @azure/app-configuration-provider is developed by the App Configuration team. They are both client libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Configuration Azure.ApplicationModel.Configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants