-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure App Configuration - Advertise @azure/configuration-provider in README #33152
base: main
Are you sure you want to change the base?
Azure App Configuration - Advertise @azure/configuration-provider in README #33152
Conversation
API change check API changes are not detected in this pull request. |
@@ -1,13 +1,28 @@ | |||
# App Configuration client library for JavaScript | |||
# Azure App Configuration SDK for JavaScript |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Azure App Configuration SDK for JavaScript | |
# Azure App Configuration client library for JavaScript |
This according to the guidelines.
But, @jeremymeng @xirzec thoughts?
Guidelines: https://github.com/Azure/azure-sdk/blob/main/docs/typescript/refs.md
Template example: https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/template/template#readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why we would change the title as this is the README for @azure/app-configuration
, not a general doc for SDK related to app configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to distinguish it with @azure/app-configuration-provider. But I am ok with the original title.
This library @azure/app-configuration is developed by Azure SDK team. The @azure/app-configuration-provider is developed by the App Configuration team. They are both client libraries.
Co-authored-by: Harsha Nalluru <[email protected]>
Packages impacted by this PR
@azure/app-configuration