Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AVM Module Issue]: Microsoft.Web/sites doesn't support dnsConfiguration block #4252

Open
1 task done
JWHolding opened this issue Jan 20, 2025 · 11 comments · May be fixed by #4373
Open
1 task done

[AVM Module Issue]: Microsoft.Web/sites doesn't support dnsConfiguration block #4252

JWHolding opened this issue Jan 20, 2025 · 11 comments · May be fixed by #4373
Assignees
@tsc-buddy
Labels
Class: Resource Module 📦 This is a resource module Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request

Comments

@JWHolding
Copy link

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/web/site

(Optional) Module Version

No response

Description

Currently the module doesnt support setting a dnsConfiguration block for the resource web.site I would like to ask for this to be added

(Optional) Correlation Id

No response
@JWHolding JWHolding added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jan 20, 2025
@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Jan 20, 2025
@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Jan 20, 2025
@avm-team-linter AVM Team Linter
Copy link

@JWHolding, thanks for submitting this issue for the avm/res/web/site module!

Important

A member of the @Azure/avm-res-web-site-module-owners-bicep or @Azure/avm-res-web-site-module-contributors-bicep team will review it soon!

@JWHolding
Copy link
Author

Param:

param vnetDnsConfiguration vnetDnsConfigurationType?

Resource:

resource app 'Microsoft.Web/sites@2024-04-01' = {
  ...
  dnsConfiguration: vnetDnsConfiguration
}

Type:

type vnetDnsConfigurationType = {
  dnsAltServer: string?
  dnsMaxCacheTimeout: int?
  dnsRetryAttemptCount: int?
  dnsRetryAttemptTimeout: int?
  dnsServers: string[]?
}

@microsoft-github-policy-service microsoft-github-policy-service bot added Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed labels Jan 23, 2025
@JWHolding JWHolding linked a pull request Feb 4, 2025 that will close this issue
Open
11 tasks
@JWHolding
Copy link
Author

@AlexanderSehr sorry to pull you in directly, how can I get this progressed if the module owner isn't responding?

@AlexanderSehr
Copy link
Contributor

Hey @JWHolding,
all good. I can reach out internally to give the owner a ping. It's a bit unfortunate that he has not been able to respond to the issue yet, but this may just be attributed to customer committments, vacation, etc..
In the meantime I'll also take a look at the PR and will add some notes over there :)

@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Caution

**This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days. **

Tip

  • To avoid this rule being (re)triggered, the "Needs: Triage 🔍" and "Status: Response Overdue 🚩" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention ‼️" label once the issue has been responded to.

@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

1 similar comment
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Caution

**This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days. **

Tip

  • To avoid this rule being (re)triggered, the "Needs: Triage 🔍" and "Status: Response Overdue 🚩" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention ‼️" label once the issue has been responded to.

@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Caution

**This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days. **

Tip

  • To avoid this rule being (re)triggered, the "Needs: Triage 🔍" and "Status: Response Overdue 🚩" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention ‼️" label once the issue has been responded to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsc-buddy tsc-buddy

Labels
Class: Resource Module 📦 This is a resource module Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
AVM - Module Issues
Status: Needs: Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: site dns configuration JWHolding/bicep-registry-modules
3 participants
@AlexanderSehr @JWHolding @tsc-buddy