feat: site dns configuration #4373
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avm-team-linter
bot
added
the
Needs: Module Owner 📣
microsoft-github-policy-service
bot
added
Needs: Triage 🔍
JWHolding
changed the title
|
@microsoft-github-policy-service agree |
AlexanderSehr
requested changes
Feb 5, 2025
There was a problem hiding this comment.
Hey @JWHolding,
overall a straight forward, great implementation. Thank you 💪
A few notes on my side
- I added to suggestions which can be committed directly via the UI
- Next, I'd like to ask you if it would be possible to add a usage example of (a subset of) the properties to e.g. the
webApp.maxtest - Each change will require an update of the JSON & markdown files which is why I'd ask you to please re-run the
Set-AVMModulescript after the changes are in - Finally, it would be great if you could attach a pipeline badge or any other sort of 'proof' that the changes work (especially with a modified test file). This is important both for the deployment & static tests. For context: If we would've merged the changes in as is, the static validation would've failed in main due to one of the code-suggestions I made. While not breaking anything, this means that the module would not be published with the new feature until the issue is fixed, yadi yada.
Hence, the more 'sure' we can be that the changes work before merging a PR, the better.
| @@ -294,6 +297,7 @@ resource app 'Microsoft.Web/sites@2024-04-01' = { | |||
| vnetContentShareEnabled: vnetContentShareEnabled | |||
| vnetImagePullEnabled: vnetImagePullEnabled | |||
| vnetRouteAllEnabled: vnetRouteAllEnabled | |||
| dnsConfiguration: vnetDnsConfiguration | |||
There was a problem hiding this comment.
Would it maybe make sense to add the same setting to the slot child module?
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
AlexanderSehr
requested changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4252
Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.