Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New module avm/ptn/authorization/pim-role-assignment #4431

Open
wants to merge 63 commits into
base: main
Choose a base branch
from
Open

feat: New module avm/ptn/authorization/pim-role-assignment #4431

wants to merge 63 commits into from
+3,629 −0

Conversation

sebassem
Copy link
Contributor

@sebassem sebassem commented Feb 11, 2025 •
edited by AlexanderSehr
Loading

Description

New pattern for PIM role assignments

  • @Azure/avm-core-team-technical-bicep TODO: Add custom secret 'userPrinicipalId' to AVM CI using user "AVM CI Validation User 001"

Pipeline Reference

Pipeline
avm.ptn.authorization.pim-role-assignment

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

sebassem added 30 commits January 22, 2025 08:33
@sebassem
initial commit
4bea691
@sebassem
feat: Update PIM Role Assignment metadata and descriptions for clarity
900a030
@sebassem
feat: Refactor PIM Role Assignment tests by removing obsolete depende…
bf2e2d8 
…ncies and adding new test modules for various scopes
@sebassem
feat: Add GitHub Actions workflow for PIM Role Assignment authorization
c7afd06
@sebassem
feat: Add userPrincipalId parameter to test Bicep files for tenant-sp…
20b0564 
…ecific role assignments
@sebassem
feat: Add PIM Role Assignment to issue template for better tracking
edd5924
@sebassem
feat: Implement new logging mechanism for improved error tracking
8b441d6
@sebassem
feat: Update README and Bicep files to clarify scheduleInfo parameter…
3f4a279 
… as required and improve descriptions
@sebassem
feat: Update CODEOWNERS to include new role assignment paths for impr…
dceb7d1 
…oved ownership tracking
@sebassem
feat: Add namePrefix parameter to Bicep test files for resource namin…
50762c6 
…g flexibility
@sebassem
feat: Update roleDefinitionIdOrName from 'Resource Policy Contributor…
4d9fee8 
…' to 'Contributor' for consistency across documentation and tests
@sebassem
Merge branch 'Azure:main' into ptn-authorization-pim-role-assignment
ed4a148
@sebassem
Merge branch 'Azure:main' into ptn-authorization-pim-role-assignment
5bb15c2
@sebassem
Merge branch 'Azure:main' into ptn-authorization-pim-role-assignment
b1d95a6
@sebassem
feat: Enhance PIM role assignment module with eligible role support a…
0e59e83 
…nd updated metadata
@sebassem
feat: Add optional start date parameter for role assignment and enhan…
a3f29c2 
…ce resource removal logic
@sebassem
feat: Update role definition in e2e test to use Resource Policy Contr…
c138874 
…ibutor
@sebassem
fix: Correct serviceShort parameter value in e2e test configuration
5986dff
@sebassem
fix: Update requestType from 'AdminAssign' to 'AdminUpdate' in e2e te…
54a0851 
…st configuration
@sebassem
fix: Update requestType to 'AdminAssign' and roleDefinitionIdOrName i…
f49d5f1 
…n e2e test configuration
@sebassem
feat: Enhance PIM role assignment logic with active and eligible type…
e1ba129 
…s, add start and end date parameters
@sebassem
feat: Update justification parameter in e2e tests to 'AVM test' and e…
96d8229 
…nhance resource removal logic
@sebassem
feat: Enhance resource removal logic to include role assignment sched…
1b79499 
…ule requests with AVM test justification
@sebassem
fix: Update roleDefinitionIdOrName in e2e test configurations for con…
e67034a 
…sistency
@sebassem
refactor: Enable role assignment module for subscription when resourc…
9a48245 
…e group name is empty
@sebassem
fix: Update date format for role assignment schedule requests to ISO …
540ab56 
…8601
@sebassem
fix: Correct date format in resource removal script to use ISO 8601
8b0469f
@sebassem
fix: Access first element of role assignment schedule requests to ret…
70e3481 
…rieve PrincipalId and RoleDefinitionId
@sebassem
fix: Add verbose logging for role assignment removal process
c61c714
@sebassem
fix: Iterate over role assignment requests to handle multiple assignm…
5e2ff70 
…ents during removal
@sebassem sebassem requested review from a team as code owners February 13, 2025 09:38
@sebassem
```
96f3f87 
fix: update documentation for resource removal process
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr left review comments

@eriqua eriqua eriqua left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@AlexanderSehr AlexanderSehr

@sebassem sebassem

Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebassem @AlexanderSehr @eriqua