Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Removed redundancies across several modules #4456

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: Removed redundancies across several modules #4456

wants to merge 4 commits into from

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Feb 16, 2025 •
edited
Loading

Description

Removed now redundant fallback values as per Azure/Azure-Verified-Modules#1858

Pipeline Reference

Pipeline
avm.ptn.app.container-job-toolkit.yml
avm.ptn.virtual-machine-images.azure-image-builder
avm.res.app-configuration.configuration-store
avm.res.automation.automation-account (unrelated)
avm.res.batch.batch-account
avm.res.cache.redis
avm.res.container-instance.container-group
avm.res.container-registry.registry
avm.res.data-factory.factory
avm.res.db-for-my-sql.flexible-server
avm.res.db-for-postgre-sql.flexible-server
avm.res.document-db.database-account
avm.res.document-db.mongo-cluster (unrelated)
avm.res.elastic-san.elastic-san (unrelated)
avm.res.event-hub.namespace
avm.res.kusto.cluster
avm.res.load-test-service.load-test
avm.res.machine-learning-services.workspace
avm.res.net-app.net-app-account
avm.res.recovery-services.vault
avm.res.search.search-service
avm.res.service-bus.namespace
avm.res.sql.server
avm.res.storage.storage-account
avm.res.synapse.workspace
avm.res.virtual-machine-images.image-template
avm.res.web.site

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Feb 16, 2025
@AlexanderSehr AlexanderSehr added the Class: Resource Module 📦 This is a resource module label Feb 16, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Feb 16, 2025
@AlexanderSehr AlexanderSehr requested review from a team as code owners February 17, 2025 09:03
AlexanderSehr
AlexanderSehr commented Feb 17, 2025
View reviewed changes
avm/ptn/app/container-job-toolkit/modules/deploy_services.bicep
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is ready for review, but needs the JSON files generated once reviewed

oZakari
oZakari previously approved these changes Feb 18, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbud peterbud peterbud approved these changes

@oZakari oZakari oZakari left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@AlexanderSehr AlexanderSehr

Labels
Class: Resource Module 📦 This is a resource module Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexanderSehr @peterbud @oZakari