Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update avm/res/net-app/net-app-account - fix optional zone for volumes and specify protocolTypes options #4469

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

thecmdradama
Copy link
Contributor

@thecmdradama thecmdradama commented Feb 18, 2025

Description

This PR resolves the following issues in the avm/res/net-app/net-app-account module

  • On the NetApp Volume submodule, zone has been renamed to availabilityZone.
  • The type for availabilityZone has been changed to string from int[] and is now optional with null as the default. Previously the module would try and deploy a volume into all three zones if no value is defined.
  • Changed: protocolTypes is now an optional array of strings with three possible options 'NFSv3', 'NFSv4.1', and 'CIFS'. If no value is provided, the default value of ['NFSv3'] is used.
  • Added to the description for protocolTypes indicating that the user will need to specify ['NFSv3','CIFS'] or ['NFSv4.1','CIFS'] if creating dual-stack volumes.
  • Added in additional submodule README.md and main.json files generated by Set-AVMModule.

Pipeline Reference

Pipeline
avm.res.net-app.net-app-account

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Feb 18, 2025
@thecmdradama thecmdradama marked this pull request as ready for review February 18, 2025 06:29
@thecmdradama thecmdradama requested review from a team as code owners February 18, 2025 06:29
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Feb 18, 2025
@thecmdradama thecmdradama changed the title fix: Update avm/res/net-app/net-app-account - fix optional zone for volumes and specify protocolTypes options fix: Update avm/res/net-app/net-app-account - fix optional zone for volumes and specify protocolTypes options Feb 18, 2025
@AlexanderSehr
Copy link
Contributor

AlexanderSehr commented Feb 22, 2025

Hey @fbinotto,
please review at your earliest convenience :)
The PR looks good from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Module Owner 📣 This module needs an owner to develop or maintain it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants