-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update avm/res/net-app/net-app-account
- fix optional zone for volumes and specify protocolTypes
options
#4469
Open
thecmdradama
wants to merge
9
commits into
Azure:main
Choose a base branch
from
thecmdradama:fix/netapp-pattern
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update avm/res/net-app/net-app-account
- fix optional zone for volumes and specify protocolTypes
optionsavm/res/net-app/net-app-account
- fix optional zone for volumes and specify protocolTypes
options
avm/res/net-app/net-app-account/capacity-pool/volume/main.bicep
Outdated
Show resolved
Hide resolved
Hey @fbinotto, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs: Module Owner 📣
This module needs an owner to develop or maintain it
Needs: Triage 🔍
Maintainers need to triage still
Type: AVM 🅰️ ✌️ Ⓜ️
This is an AVM related issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the following issues in the
avm/res/net-app/net-app-account
modulezone
has been renamed toavailabilityZone
.availabilityZone
has been changed tostring
fromint[]
and is now optional with null as the default. Previously the module would try and deploy a volume into all three zones if no value is defined.protocolTypes
is now an optional array of strings with three possible options'NFSv3', 'NFSv4.1', and 'CIFS'
. If no value is provided, the default value of['NFSv3']
is used.protocolTypes
indicating that the user will need to specify['NFSv3','CIFS']
or['NFSv4.1','CIFS']
if creating dual-stack volumes.Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.