Fixes bug where the aberrated coordinates were misaligned with epheme… #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Python Benchmark
| Benchmark suite | Current: 38a9f21 | Previous: 16d9421 | Ratio |
|---|---|---|---|
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[1-origin=SUN,-frame=equatorial,-to=SphericalCoordinates,] |
430.6938468298455 iter/sec (stddev: 0.00010258505618262545) |
440.8813880260027 iter/sec (stddev: 0.00008842208270532047) |
1.02 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[1-origin=SUN,-frame=equatorial,-to=KeplerianCoordinates,] |
287.8758550351036 iter/sec (stddev: 0.00025630696638102873) |
293.3062756330693 iter/sec (stddev: 0.00020124096044040973) |
1.02 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[1-origin=SUN,-frame=equatorial,-to=CometaryCoordinates,] |
311.5514232746311 iter/sec (stddev: 0.00017367493203465772) |
317.6671944392813 iter/sec (stddev: 0.0001567034389383326) |
1.02 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[1-origin=SUN,-frame=ecliptic,-to=SphericalCoordinates,] |
436.38460408632443 iter/sec (stddev: 0.00004829729834160934) |
441.65824933379 iter/sec (stddev: 0.00005973756274861252) |
1.01 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[1-origin=SUN,-frame=ecliptic,-to=KeplerianCoordinates,] |
299.28286406038154 iter/sec (stddev: 0.000058226079609002775) |
298.8671983449959 iter/sec (stddev: 0.00015704487894391056) |
1.00 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[1-origin=SUN,-frame=ecliptic,-to=CometaryCoordinates,] |
326.0105727601105 iter/sec (stddev: 0.00005282956437952855) |
324.6181158690973 iter/sec (stddev: 0.00008166972315692588) |
1.00 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[50-origin=SUN,-frame=equatorial,-to=SphericalCoordinates,] |
415.0827738210708 iter/sec (stddev: 0.00008297305654601843) |
409.6592376460921 iter/sec (stddev: 0.00005090759008154338) |
0.99 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[50-origin=SUN,-frame=equatorial,-to=KeplerianCoordinates,] |
258.96699490026174 iter/sec (stddev: 0.000049314672070674194) |
257.28077713477165 iter/sec (stddev: 0.00008552693051070864) |
0.99 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[50-origin=SUN,-frame=equatorial,-to=CometaryCoordinates,] |
260.71861140765685 iter/sec (stddev: 0.0002670277309443754) |
265.07299129522085 iter/sec (stddev: 0.00015043350864619304) |
1.02 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[50-origin=SUN,-frame=ecliptic,-to=SphericalCoordinates,] |
416.0556014299952 iter/sec (stddev: 0.00004011953135716358) |
412.4085395197432 iter/sec (stddev: 0.0000826641804076833) |
0.99 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[50-origin=SUN,-frame=ecliptic,-to=KeplerianCoordinates,] |
257.1434204805453 iter/sec (stddev: 0.00013383875161408738) |
258.38015340758585 iter/sec (stddev: 0.00005655955020774578) |
1.00 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[50-origin=SUN,-frame=ecliptic,-to=CometaryCoordinates,] |
265.20456127978866 iter/sec (stddev: 0.00012303560118895332) |
267.606346851155 iter/sec (stddev: 0.00007634137643806421) |
1.01 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[100-origin=SUN,-frame=equatorial,-to=SphericalCoordinates,] |
404.1372532539661 iter/sec (stddev: 0.000039754815454518695) |
396.8782899822016 iter/sec (stddev: 0.00008958178671185646) |
0.98 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[100-origin=SUN,-frame=equatorial,-to=KeplerianCoordinates,] |
227.737176133837 iter/sec (stddev: 0.00005586663144624894) |
226.9577485531786 iter/sec (stddev: 0.00006664527462902324) |
1.00 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[100-origin=SUN,-frame=equatorial,-to=CometaryCoordinates,] |
230.47272583410086 iter/sec (stddev: 0.00017023512419705515) |
234.38610037958142 iter/sec (stddev: 0.000166515380112634) |
1.02 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[100-origin=SUN,-frame=ecliptic,-to=SphericalCoordinates,] |
405.6574091847621 iter/sec (stddev: 0.00005446216640424871) |
406.1524847662961 iter/sec (stddev: 0.00004855309795423447) |
1.00 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[100-origin=SUN,-frame=ecliptic,-to=KeplerianCoordinates,] |
226.15951470635088 iter/sec (stddev: 0.00015578062749855667) |
219.3674309334062 iter/sec (stddev: 0.00022736185256630044) |
0.97 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[100-origin=SUN,-frame=ecliptic,-to=CometaryCoordinates,] |
232.86615924447952 iter/sec (stddev: 0.000046631975883773837) |
228.6871901459629 iter/sec (stddev: 0.0000712682499625294) |
0.98 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_CoordinateCovariances_to_matrix |
605.4965227329974 iter/sec (stddev: 0.000014530196324625934) |
644.6238567817701 iter/sec (stddev: 0.000019743647237097997) |
1.06 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_CoordinateCovariances_from_matrix |
10797.067717430125 iter/sec (stddev: 0.000008218613107715196) |
10777.795915996934 iter/sec (stddev: 0.000005522117911464615) |
1.00 |
src/adam_core/dynamics/tests/test_propagation.py::test_benchmark__propagate_2body |
43050.253962242736 iter/sec (stddev: 0.000009330720433680196) |
43878.03854583232 iter/sec (stddev: 0.000009042112605231) |
1.02 |
src/adam_core/dynamics/tests/test_propagation.py::test_benchmark__propagate_2body_vmap |
34061.105619211994 iter/sec (stddev: 0.000010623915224283192) |
34291.87280939709 iter/sec (stddev: 0.000010147079878976736) |
1.01 |
src/adam_core/dynamics/tests/test_propagation.py::test_benchmark_propagate_2body |
337.10888543137213 iter/sec (stddev: 0.00011169193309629569) |
337.45658410114606 iter/sec (stddev: 0.00007049274904757485) |
1.00 |
src/adam_core/dynamics/tests/test_propagation.py::test_benchmark_propagate_2body_matrix |
4.0197104378915425 iter/sec (stddev: 0.000399768375423321) |
3.9599550715537295 iter/sec (stddev: 0.0008649169415056774) |
0.99 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=equatorial,-code=X05,-times=1,] |
563.5255045237175 iter/sec (stddev: 0.00003187763235837161) |
564.122535525084 iter/sec (stddev: 0.00003482331883493901) |
1.00 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=equatorial,-code=X05,-times=10000,] |
4.549851716555993 iter/sec (stddev: 0.002136505034565455) |
4.682792036492729 iter/sec (stddev: 0.000866702311163321) |
1.03 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=equatorial,-code=500,-times=1,] |
1162.147356712866 iter/sec (stddev: 0.00003557389203317879) |
1164.2969153531942 iter/sec (stddev: 0.000025720227760086945) |
1.00 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=equatorial,-code=500,-times=10000,] |
16.690514564773437 iter/sec (stddev: 0.00018883657459450761) |
17.078764232958406 iter/sec (stddev: 0.0003444602480970953) |
1.02 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=ecliptic,-code=X05,-times=1,] |
568.3846755850469 iter/sec (stddev: 0.00006270128246270315) |
561.9905247481902 iter/sec (stddev: 0.000055771739382969643) |
0.99 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=ecliptic,-code=X05,-times=10000,] |
4.571238157156451 iter/sec (stddev: 0.0002975980386598722) |
4.685212790389627 iter/sec (stddev: 0.0005436866840030911) |
1.02 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=ecliptic,-code=500,-times=1,] |
1171.8275008681546 iter/sec (stddev: 0.000014446463924027051) |
1163.7413596497242 iter/sec (stddev: 0.0000643371424294948) |
0.99 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=ecliptic,-code=500,-times=10000,] |
16.572703273571978 iter/sec (stddev: 0.0003013341871052483) |
16.901283843293317 iter/sec (stddev: 0.0012934195906635529) |
1.02 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-code=X05,-times=1,] |
568.2264826076112 iter/sec (stddev: 0.00004828385259293302) |
574.6977746632316 iter/sec (stddev: 0.00003482766454222119) |
1.01 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-code=X05,-times=10000,] |
4.581735320651991 iter/sec (stddev: 0.0018584020191764181) |
4.679652147305007 iter/sec (stddev: 0.0011987770932856154) |
1.02 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-code=500,-times=1,] |
1175.7677218913038 iter/sec (stddev: 0.000015122486474094262) |
1167.776525660984 iter/sec (stddev: 0.00003745012270884351) |
0.99 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-code=500,-times=10000,] |
16.912043926506158 iter/sec (stddev: 0.0002100194064701128) |
17.43040217137851 iter/sec (stddev: 0.0004126168493188322) |
1.03 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-code=X05,-times=1,] |
571.2824559544497 iter/sec (stddev: 0.000019781253661234435) |
567.4461466200381 iter/sec (stddev: 0.00003528002730376115) |
0.99 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-code=X05,-times=10000,] |
4.582521961541975 iter/sec (stddev: 0.00029592483464097166) |
4.694778470577855 iter/sec (stddev: 0.0005985102946143851) |
1.02 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-code=500,-times=1,] |
1174.4875050283677 iter/sec (stddev: 0.000017044390445731917) |
1160.067937413106 iter/sec (stddev: 0.0000251623164431481) |
0.99 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-code=500,-times=10000,] |
16.917033269309673 iter/sec (stddev: 0.00019613780846702906) |
17.290200642964603 iter/sec (stddev: 0.0006963985601179963) |
1.02 |
src/adam_core/orbits/tests/test_benchmarks.py::test_benchmark_iterate_real_orbits |
16397.896103091738 iter/sec (stddev: 0.000002140720526987578) |
19402.30017927111 iter/sec (stddev: 0.000004547087180119796) |
1.18 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=equatorial,-perturber=EARTH,-times=1,] |
1423.8265296145646 iter/sec (stddev: 0.000016917794351229624) |
1435.0386599277163 iter/sec (stddev: 0.00002085773228701962) |
1.01 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=equatorial,-perturber=EARTH,-times=10000,] |
16.68208036921375 iter/sec (stddev: 0.0001469148948346956) |
17.192550950592455 iter/sec (stddev: 0.0011666417484373969) |
1.03 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=equatorial,-perturber=SUN,-times=1,] |
1439.3362172916713 iter/sec (stddev: 0.00001529634632609999) |
1464.795114774486 iter/sec (stddev: 0.000025651439111821925) |
1.02 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=equatorial,-perturber=SUN,-times=10000,] |
18.278715471659154 iter/sec (stddev: 0.000302006299206307) |
19.10068590114432 iter/sec (stddev: 0.0003104848325041872) |
1.04 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=equatorial,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=1,] |
1425.6680271130813 iter/sec (stddev: 0.000018401579423126817) |
1440.3580525979257 iter/sec (stddev: 0.0000184799659138364) |
1.01 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=equatorial,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=10000,] |
17.318679661077347 iter/sec (stddev: 0.0010744593006160544) |
17.957307316548565 iter/sec (stddev: 0.0011234844156421237) |
1.04 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=ecliptic,-perturber=EARTH,-times=1,] |
1409.4474180365578 iter/sec (stddev: 0.00001531680391968541) |
1439.0114771580659 iter/sec (stddev: 0.000019124416160692504) |
1.02 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=ecliptic,-perturber=EARTH,-times=10000,] |
16.537558064351092 iter/sec (stddev: 0.0011621212243819014) |
16.9962503042546 iter/sec (stddev: 0.0012130794582209683) |
1.03 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=ecliptic,-perturber=SUN,-times=1,] |
1423.1397189231575 iter/sec (stddev: 0.00001466708391959381) |
1445.5647227216546 iter/sec (stddev: 0.000030414399478148474) |
1.02 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=ecliptic,-perturber=SUN,-times=10000,] |
18.236199295959484 iter/sec (stddev: 0.0011089609943643187) |
18.9982527933846 iter/sec (stddev: 0.001328255814714612) |
1.04 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=ecliptic,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=1,] |
1419.6192217526732 iter/sec (stddev: 0.000014983768212363655) |
1425.9563141244196 iter/sec (stddev: 0.00002188658025986457) |
1.00 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=ecliptic,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=10000,] |
17.271824905362074 iter/sec (stddev: 0.0001309814524970534) |
17.84320207665003 iter/sec (stddev: 0.0011403873349016753) |
1.03 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-perturber=EARTH,-times=1,] |
1423.452141153294 iter/sec (stddev: 0.000028144088873459492) |
1424.742947189324 iter/sec (stddev: 0.000034435024138906414) |
1.00 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-perturber=EARTH,-times=10000,] |
16.852327887343062 iter/sec (stddev: 0.0012837083754543297) |
17.45091089304975 iter/sec (stddev: 0.0011991188880202555) |
1.04 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-perturber=SUN,-times=1,] |
1419.2649715956436 iter/sec (stddev: 0.000029499247468484317) |
1438.8923005601746 iter/sec (stddev: 0.000023238456283618124) |
1.01 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-perturber=SUN,-times=10000,] |
17.191858655507787 iter/sec (stddev: 0.002426579762233271) |
17.967212092344873 iter/sec (stddev: 0.0010563240190419694) |
1.05 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=1,] |
1430.3575671713688 iter/sec (stddev: 0.00003048856656917614) |
1452.0466008336043 iter/sec (stddev: 0.000020601106199217282) |
1.02 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=10000,] |
18.20290836757841 iter/sec (stddev: 0.0008472589332032278) |
18.960607706878072 iter/sec (stddev: 0.0011069379830112652) |
1.04 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-perturber=EARTH,-times=1,] |
1409.7320419150055 iter/sec (stddev: 0.000019112058857208125) |
1427.632435490084 iter/sec (stddev: 0.000022115273534238) |
1.01 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-perturber=EARTH,-times=10000,] |
16.58577443005375 iter/sec (stddev: 0.0006560630704303297) |
17.340721363082572 iter/sec (stddev: 0.0010658466074203448) |
1.05 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-perturber=SUN,-times=1,] |
1422.9086924516337 iter/sec (stddev: 0.000014963823565078373) |
1436.2640001291345 iter/sec (stddev: 0.000020718193403409736) |
1.01 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-perturber=SUN,-times=10000,] |
17.149812306401557 iter/sec (stddev: 0.00031395367546871726) |
17.894895209833646 iter/sec (stddev: 0.00031115950530122435) |
1.04 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=1,] |
1427.0344825983082 iter/sec (stddev: 0.00002616975520591898) |
1442.9237581179639 iter/sec (stddev: 0.00003839900654761107) |
1.01 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=10000,] |
18.165331870601147 iter/sec (stddev: 0.0002106308623369507) |
18.981363873917232 iter/sec (stddev: 0.0012260234323935252) |
1.04 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ris produced