-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to adam_core functions for close approach work #133
Open
KatKiker
wants to merge
3
commits into
main
Choose a base branch
from
kk/close-approach
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python Benchmark
Benchmark suite | Current: 9517ae1 | Previous: 20aa441 | Ratio |
---|---|---|---|
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[1-origin=SUN,-frame=equatorial,-to=SphericalCoordinates,] |
426.135599433482 iter/sec (stddev: 0.0000911580246254494 ) |
407.5525095181881 iter/sec (stddev: 0.00009629078221799857 ) |
0.96 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[1-origin=SUN,-frame=equatorial,-to=KeplerianCoordinates,] |
292.6509151012959 iter/sec (stddev: 0.000178033371072294 ) |
283.2907094120397 iter/sec (stddev: 0.0002089002776206655 ) |
0.97 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[1-origin=SUN,-frame=equatorial,-to=CometaryCoordinates,] |
308.6875924774134 iter/sec (stddev: 0.00015376289532019835 ) |
303.51714453014245 iter/sec (stddev: 0.00018646490815015757 ) |
0.98 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[1-origin=SUN,-frame=ecliptic,-to=SphericalCoordinates,] |
440.62595254217376 iter/sec (stddev: 0.00003226149322401655 ) |
418.8501258993394 iter/sec (stddev: 0.00016293836489198198 ) |
0.95 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[1-origin=SUN,-frame=ecliptic,-to=KeplerianCoordinates,] |
299.90476583720704 iter/sec (stddev: 0.00011991929078976336 ) |
300.00362459894444 iter/sec (stddev: 0.00007391898196352988 ) |
1.00 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[1-origin=SUN,-frame=ecliptic,-to=CometaryCoordinates,] |
320.60886171479166 iter/sec (stddev: 0.0001005221653770921 ) |
318.9686517753833 iter/sec (stddev: 0.0000466513198430893 ) |
0.99 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[50-origin=SUN,-frame=equatorial,-to=SphericalCoordinates,] |
414.2292289119757 iter/sec (stddev: 0.0000836272944064936 ) |
402.31586978622005 iter/sec (stddev: 0.000037609906904184026 ) |
0.97 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[50-origin=SUN,-frame=equatorial,-to=KeplerianCoordinates,] |
259.46559496752377 iter/sec (stddev: 0.00006337696581707795 ) |
255.11661890917085 iter/sec (stddev: 0.00010211439793314945 ) |
0.98 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[50-origin=SUN,-frame=equatorial,-to=CometaryCoordinates,] |
259.43967360855936 iter/sec (stddev: 0.0002012004981166388 ) |
255.78503907222154 iter/sec (stddev: 0.00019716224849059853 ) |
0.99 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[50-origin=SUN,-frame=ecliptic,-to=SphericalCoordinates,] |
418.31799157429464 iter/sec (stddev: 0.00009044283592102524 ) |
409.75803140099316 iter/sec (stddev: 0.000047826959801956154 ) |
0.98 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[50-origin=SUN,-frame=ecliptic,-to=KeplerianCoordinates,] |
258.1914737450369 iter/sec (stddev: 0.00006181340794600553 ) |
257.4852765370619 iter/sec (stddev: 0.00003226363246554616 ) |
1.00 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[50-origin=SUN,-frame=ecliptic,-to=CometaryCoordinates,] |
265.56118039239215 iter/sec (stddev: 0.00020378235131005354 ) |
261.6602280347285 iter/sec (stddev: 0.00014329653011012713 ) |
0.99 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[100-origin=SUN,-frame=equatorial,-to=SphericalCoordinates,] |
406.4714954284424 iter/sec (stddev: 0.00005284207268681521 ) |
396.1106418123462 iter/sec (stddev: 0.00005543330812494019 ) |
0.97 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[100-origin=SUN,-frame=equatorial,-to=KeplerianCoordinates,] |
227.61493679552902 iter/sec (stddev: 0.00004752244266773902 ) |
224.19525060902387 iter/sec (stddev: 0.00005059266229305605 ) |
0.98 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[100-origin=SUN,-frame=equatorial,-to=CometaryCoordinates,] |
231.68746880364154 iter/sec (stddev: 0.00016700942065281515 ) |
226.281726451933 iter/sec (stddev: 0.00021823310241961765 ) |
0.98 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[100-origin=SUN,-frame=ecliptic,-to=SphericalCoordinates,] |
408.72538252090527 iter/sec (stddev: 0.00016842765625499687 ) |
399.96011147176523 iter/sec (stddev: 0.00003347521320958857 ) |
0.98 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[100-origin=SUN,-frame=ecliptic,-to=KeplerianCoordinates,] |
229.9531333140036 iter/sec (stddev: 0.00014369578367531266 ) |
226.24572045970348 iter/sec (stddev: 0.000029833760212670996 ) |
0.98 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[100-origin=SUN,-frame=ecliptic,-to=CometaryCoordinates,] |
236.8675120954221 iter/sec (stddev: 0.00007826406439601682 ) |
230.42515708862805 iter/sec (stddev: 0.000030026666818382876 ) |
0.97 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_CoordinateCovariances_to_matrix |
651.8536322370679 iter/sec (stddev: 0.000012953154216102493 ) |
655.0175711232993 iter/sec (stddev: 0.00010038904529697916 ) |
1.00 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_CoordinateCovariances_from_matrix |
10910.010602564302 iter/sec (stddev: 0.000007083755593288316 ) |
10568.996637854489 iter/sec (stddev: 0.000007241866855517779 ) |
0.97 |
src/adam_core/dynamics/tests/test_propagation.py::test_benchmark__propagate_2body |
46136.5745163893 iter/sec (stddev: 0.000009113098760432721 ) |
37787.97586954804 iter/sec (stddev: 0.00001905617020827393 ) |
0.82 |
src/adam_core/dynamics/tests/test_propagation.py::test_benchmark__propagate_2body_vmap |
35224.02479000282 iter/sec (stddev: 0.000009879879759354023 ) |
34423.57719926941 iter/sec (stddev: 0.000010576306171882923 ) |
0.98 |
src/adam_core/dynamics/tests/test_propagation.py::test_benchmark_propagate_2body |
331.04871100298755 iter/sec (stddev: 0.0000798283599467514 ) |
301.5983051395936 iter/sec (stddev: 0.00027572430371906653 ) |
0.91 |
src/adam_core/dynamics/tests/test_propagation.py::test_benchmark_propagate_2body_matrix |
3.89426489474885 iter/sec (stddev: 0.0018855657542924354 ) |
3.889990487082706 iter/sec (stddev: 0.0004442228158010418 ) |
1.00 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=equatorial,-code=X05,-times=1,] |
547.9208399755248 iter/sec (stddev: 0.000032196930772162816 ) |
541.7122266117938 iter/sec (stddev: 0.000020808173045818673 ) |
0.99 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=equatorial,-code=X05,-times=10000,] |
4.849392541910529 iter/sec (stddev: 0.0018959182285246971 ) |
4.818340585570695 iter/sec (stddev: 0.0016118875238940213 ) |
0.99 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=equatorial,-code=500,-times=1,] |
1135.0762767619403 iter/sec (stddev: 0.000015794234086539765 ) |
1106.315098212147 iter/sec (stddev: 0.000020701536024819438 ) |
0.97 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=equatorial,-code=500,-times=10000,] |
17.785270725506503 iter/sec (stddev: 0.00027242725400822743 ) |
17.580419725490035 iter/sec (stddev: 0.0001325474145378345 ) |
0.99 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=ecliptic,-code=X05,-times=1,] |
553.3454284081446 iter/sec (stddev: 0.00012126291675930099 ) |
541.6809704189756 iter/sec (stddev: 0.00006605163598089961 ) |
0.98 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=ecliptic,-code=X05,-times=10000,] |
4.842182559478245 iter/sec (stddev: 0.0013422984782023822 ) |
4.816117512527908 iter/sec (stddev: 0.002190999289289382 ) |
0.99 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=ecliptic,-code=500,-times=1,] |
1142.6047900878093 iter/sec (stddev: 0.00003586837933230391 ) |
1112.254053755273 iter/sec (stddev: 0.000034939119578288784 ) |
0.97 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=ecliptic,-code=500,-times=10000,] |
17.71748289988427 iter/sec (stddev: 0.000201932338300023 ) |
17.4056439581699 iter/sec (stddev: 0.0011278731084151867 ) |
0.98 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-code=X05,-times=1,] |
554.3880977060995 iter/sec (stddev: 0.00006373374651173445 ) |
543.7292008196445 iter/sec (stddev: 0.0000205145391638096 ) |
0.98 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-code=X05,-times=10000,] |
4.906490297416671 iter/sec (stddev: 0.0007031123479660998 ) |
4.858639166416716 iter/sec (stddev: 0.0020978121836031393 ) |
0.99 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-code=500,-times=1,] |
1138.1739664185807 iter/sec (stddev: 0.0000346634180316867 ) |
1114.9104142660583 iter/sec (stddev: 0.00003265740757026978 ) |
0.98 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-code=500,-times=10000,] |
18.014424904733744 iter/sec (stddev: 0.0011792738282728633 ) |
17.919826231527267 iter/sec (stddev: 0.00038200645295879797 ) |
0.99 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-code=X05,-times=1,] |
562.9210712073677 iter/sec (stddev: 0.000026310763986535405 ) |
538.9407160410041 iter/sec (stddev: 0.0000366775542705371 ) |
0.96 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-code=X05,-times=10000,] |
4.857725913051973 iter/sec (stddev: 0.002097888606951882 ) |
4.8111753210568935 iter/sec (stddev: 0.0028467298445544946 ) |
0.99 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-code=500,-times=1,] |
1147.5727440582007 iter/sec (stddev: 0.000016200823199214325 ) |
1111.8978249589295 iter/sec (stddev: 0.000020687468457480466 ) |
0.97 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-code=500,-times=10000,] |
18.02647374195593 iter/sec (stddev: 0.00036504431962136727 ) |
17.76479999921809 iter/sec (stddev: 0.0002553784454943979 ) |
0.99 |
src/adam_core/orbits/tests/test_benchmarks.py::test_benchmark_iterate_real_orbits |
19457.028081662927 iter/sec (stddev: 0.0000041559270547255654 ) |
19361.163990835383 iter/sec (stddev: 0.000002576770989085466 ) |
1.00 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=equatorial,-perturber=EARTH,-times=1,] |
1405.18362651063 iter/sec (stddev: 0.000030371060681461986 ) |
1349.544237941029 iter/sec (stddev: 0.0000166961865536441 ) |
0.96 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=equatorial,-perturber=EARTH,-times=10000,] |
17.941956550504376 iter/sec (stddev: 0.0001879901107779526 ) |
17.587661720638312 iter/sec (stddev: 0.000254983931097572 ) |
0.98 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=equatorial,-perturber=SUN,-times=1,] |
1415.7766333945683 iter/sec (stddev: 0.000017388783182270213 ) |
1368.6437184031445 iter/sec (stddev: 0.000027785942244424414 ) |
0.97 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=equatorial,-perturber=SUN,-times=10000,] |
19.62855767374635 iter/sec (stddev: 0.0010539963918602224 ) |
19.65350837224558 iter/sec (stddev: 0.00022887385410772827 ) |
1.00 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=equatorial,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=1,] |
1379.1421610139475 iter/sec (stddev: 0.00003310792872542264 ) |
1353.7831871616193 iter/sec (stddev: 0.00004763519871990818 ) |
0.98 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=equatorial,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=10000,] |
18.636097417033334 iter/sec (stddev: 0.0010184452038641601 ) |
18.336628165646353 iter/sec (stddev: 0.00021153420044896825 ) |
0.98 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=ecliptic,-perturber=EARTH,-times=1,] |
1372.397935897747 iter/sec (stddev: 0.00004788860976288402 ) |
1360.308090087878 iter/sec (stddev: 0.00002323347075413757 ) |
0.99 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=ecliptic,-perturber=EARTH,-times=10000,] |
17.59455946974899 iter/sec (stddev: 0.0014475099866006562 ) |
17.320070829084003 iter/sec (stddev: 0.0016405166073851364 ) |
0.98 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=ecliptic,-perturber=SUN,-times=1,] |
1396.4190512772304 iter/sec (stddev: 0.000022147056483664825 ) |
1367.8115103965883 iter/sec (stddev: 0.000014648786120167239 ) |
0.98 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=ecliptic,-perturber=SUN,-times=10000,] |
19.706894432384775 iter/sec (stddev: 0.0002986014370145122 ) |
19.573285503842612 iter/sec (stddev: 0.001059577548086368 ) |
0.99 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=ecliptic,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=1,] |
1377.4101642264814 iter/sec (stddev: 0.000021062337527926415 ) |
1362.339794626017 iter/sec (stddev: 0.000019262344495787206 ) |
0.99 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=ecliptic,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=10000,] |
18.624612498148743 iter/sec (stddev: 0.0007910995017216099 ) |
18.42034749200145 iter/sec (stddev: 0.00017639543968405157 ) |
0.99 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-perturber=EARTH,-times=1,] |
1387.829925271077 iter/sec (stddev: 0.00002921166417744394 ) |
1356.1343038384734 iter/sec (stddev: 0.000014546935483033784 ) |
0.98 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-perturber=EARTH,-times=10000,] |
18.104763097316756 iter/sec (stddev: 0.0006506185697149345 ) |
18.01476109708186 iter/sec (stddev: 0.00012864194547481205 ) |
1.00 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-perturber=SUN,-times=1,] |
1381.0544771627897 iter/sec (stddev: 0.00004158418329307316 ) |
1352.1880219016657 iter/sec (stddev: 0.00007816096866973063 ) |
0.98 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-perturber=SUN,-times=10000,] |
18.687109706377015 iter/sec (stddev: 0.00020321173966755612 ) |
18.46889253228115 iter/sec (stddev: 0.00019540448392422246 ) |
0.99 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=1,] |
1416.194196358414 iter/sec (stddev: 0.00001921841235655598 ) |
1373.164349895174 iter/sec (stddev: 0.000018872603805776904 ) |
0.97 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=10000,] |
19.578646423189216 iter/sec (stddev: 0.0006116049604333097 ) |
19.719942795409064 iter/sec (stddev: 0.00015362438376569968 ) |
1.01 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-perturber=EARTH,-times=1,] |
1367.5629799982348 iter/sec (stddev: 0.00007507982531410295 ) |
1368.1887364166157 iter/sec (stddev: 0.000013477732360736854 ) |
1.00 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-perturber=EARTH,-times=10000,] |
18.036321616619922 iter/sec (stddev: 0.0002333347162905616 ) |
17.436727714251635 iter/sec (stddev: 0.0033446430997165185 ) |
0.97 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-perturber=SUN,-times=1,] |
1398.8443614485325 iter/sec (stddev: 0.000016297689447580075 ) |
1358.277538496387 iter/sec (stddev: 0.00002640852953609512 ) |
0.97 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-perturber=SUN,-times=10000,] |
18.52897173002517 iter/sec (stddev: 0.000245179187609476 ) |
18.354312360659907 iter/sec (stddev: 0.00015488321415004804 ) |
0.99 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=1,] |
1425.2404021233442 iter/sec (stddev: 0.0000172394851319777 ) |
1363.690320838305 iter/sec (stddev: 0.000027241443172493178 ) |
0.96 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=10000,] |
19.67169187543534 iter/sec (stddev: 0.0002519144967301297 ) |
19.61214592670886 iter/sec (stddev: 0.0010115266954918503 ) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
c5a0c74
to
9517ae1
Compare
Co-authored-by: Alec Koumjian <[email protected]> Co-authored-by: Joachim Moeyens <[email protected]>
9517ae1
to
d494656
Compare
d494656
to
d769b06
Compare
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.