Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSC control of client Pause/Resume does not function #304

Closed
amwtech opened this issue Jan 8, 2023 · 2 comments
Closed

OSC control of client Pause/Resume does not function #304

amwtech opened this issue Jan 8, 2023 · 2 comments
Labels

Comments

@amwtech
Copy link
Contributor

amwtech commented Jan 8, 2023

Client versions with the issue include 2.0.8, 2.0.9, 2.2
Operating Systems: Windows, MacOS, Linux

When a remote control enabled rundown recieves a OSC message with address /control/pause the command is ignored.

The reason is the code to add the pause command to the list of recognised commands is missing from file rundowntreewidget.cpp

The missing code is shown below:

/* Missing PAUSE connection - version 2.0.9 client branch */
QString pauseControlFilter = Osc::DEFAULT_PAUSE_RUNDOWN_CONTROL_FILTER;
this->pauseControlSubscription = new OscSubscription(pauseControlFilter, this);
QObject::connect(this->pauseControlSubscription, SIGNAL(subscriptionReceived(const QString&, const QList<QVariant>&)),
              this, SLOT(pauseControlSubscriptionReceived(const QString&, const QList<QVariant>&)));
/* Missing PAUSE connection - version 2.2.0 client branch */
QString pauseControlFilter = Osc::RUNDOWN_CONTROL_PAUSE_FILTER;
this->pauseControlSubscription = new OscSubscription(pauseControlFilter, this);
QObject::connect(this->pauseControlSubscription, SIGNAL(subscriptionReceived(const QString&, const QList<QVariant>&)),
              this, SLOT(pauseControlSubscriptionReceived(const QString&, const QList<QVariant>&)));

Add this code to function void RundownTreeWidget::configureOscSubscriptions(), for example starting at line 1804 of the version 2.2 client file set.

@Julusian
Copy link
Member

Fix applied in cb28e23
I havent tested it, hopefully it still works

@amwtech
Copy link
Contributor Author

amwtech commented Dec 18, 2023

Tested on Mac and Windows client build. Operates correctly.

inkvolcano added a commit to inkvolcano/client that referenced this issue Sep 22, 2024
commit 73683a4
Author: ServiusHack <[email protected]>
Date:   Tue Jun 11 13:30:07 2024 +0200

    Fix malformed color command CasparCG#293 (CasparCG#314)

commit bb65df8
Author: ServiusHack <[email protected]>
Date:   Tue Jun 11 09:11:31 2024 +0200

    chore: Document Qt requirements (CasparCG#313)

commit e0642dc
Author: Julian Waller <[email protected]>
Date:   Wed Apr 17 17:43:28 2024 +0100

    chore: update github workflows

commit 8d29b4f
Author: Julian Waller <[email protected]>
Date:   Wed Mar 6 09:52:00 2024 +0000

    fix: add missing formats to sql schema

commit 6d74aa3
Author: Julian Waller <[email protected]>
Date:   Wed Feb 21 17:50:26 2024 +0000

    fix: clip time not showing CasparCG/server#1521

commit 028261f
Author: Julian Waller <[email protected]>
Date:   Wed Feb 21 17:27:47 2024 +0000

    fix: target dropdown showing empty when unknown item was selected

commit 58e2267
Author: Julian Waller <[email protected]>
Date:   Tue Jan 9 21:56:41 2024 +0000

    fix: typo in CasparCG#310

commit 5118b0a
Author: Julian Waller <[email protected]>
Date:   Tue Jan 9 21:43:11 2024 +0000

    fix: typo in CasparCG#310

commit 43fab80
Merge: 21cbf4b e128c87
Author: Julian Waller <[email protected]>
Date:   Tue Jan 9 21:35:04 2024 +0000

    Merge pull request CasparCG#310 from amwtech/main

commit 21cbf4b
Author: Julian Waller <[email protected]>
Date:   Tue Jan 9 21:10:30 2024 +0000

    chore: macos code signing

commit e128c87
Author: amwtech <[email protected]>
Date:   Sun Jan 7 15:34:11 2024 +0000

    Add files via upload

commit 67a5c58
Author: Julian Waller <[email protected]>
Date:   Thu Dec 14 00:00:15 2023 +0000

    fix: Playout Command Pause or Resume does not operate CasparCG#301

commit cb28e23
Author: Julian Waller <[email protected]>
Date:   Wed Dec 13 23:58:45 2023 +0000

    fix: OSC control of client Pause/Resume does not function CasparCG#304

commit c79c5ff
Author: Julian Waller <[email protected]>
Date:   Wed Dec 13 23:55:55 2023 +0000

    fix: GPO saved rising/falling configuration does not correctly recall settings at startup CasparCG#305

commit df81415
Author: Julian Waller <[email protected]>
Date:   Wed Dec 13 23:06:15 2023 +0000

    feat: qt6 and update build tooling CasparCG#307

commit 5b5743a
Author: Julian Waller <[email protected]>
Date:   Wed Dec 13 23:21:42 2023 +0000

    wip: delete committed libraries and binaries
inkvolcano added a commit to inkvolcano/client that referenced this issue Sep 23, 2024
commit 73683a4
Author: ServiusHack <[email protected]>
Date:   Tue Jun 11 13:30:07 2024 +0200

    Fix malformed color command CasparCG#293 (CasparCG#314)

commit bb65df8
Author: ServiusHack <[email protected]>
Date:   Tue Jun 11 09:11:31 2024 +0200

    chore: Document Qt requirements (CasparCG#313)

commit e0642dc
Author: Julian Waller <[email protected]>
Date:   Wed Apr 17 17:43:28 2024 +0100

    chore: update github workflows

commit 8d29b4f
Author: Julian Waller <[email protected]>
Date:   Wed Mar 6 09:52:00 2024 +0000

    fix: add missing formats to sql schema

commit 6d74aa3
Author: Julian Waller <[email protected]>
Date:   Wed Feb 21 17:50:26 2024 +0000

    fix: clip time not showing CasparCG/server#1521

commit 028261f
Author: Julian Waller <[email protected]>
Date:   Wed Feb 21 17:27:47 2024 +0000

    fix: target dropdown showing empty when unknown item was selected

commit 58e2267
Author: Julian Waller <[email protected]>
Date:   Tue Jan 9 21:56:41 2024 +0000

    fix: typo in CasparCG#310

commit 5118b0a
Author: Julian Waller <[email protected]>
Date:   Tue Jan 9 21:43:11 2024 +0000

    fix: typo in CasparCG#310

commit 43fab80
Merge: 21cbf4b e128c87
Author: Julian Waller <[email protected]>
Date:   Tue Jan 9 21:35:04 2024 +0000

    Merge pull request CasparCG#310 from amwtech/main

commit 21cbf4b
Author: Julian Waller <[email protected]>
Date:   Tue Jan 9 21:10:30 2024 +0000

    chore: macos code signing

commit e128c87
Author: amwtech <[email protected]>
Date:   Sun Jan 7 15:34:11 2024 +0000

    Add files via upload

commit 67a5c58
Author: Julian Waller <[email protected]>
Date:   Thu Dec 14 00:00:15 2023 +0000

    fix: Playout Command Pause or Resume does not operate CasparCG#301

commit cb28e23
Author: Julian Waller <[email protected]>
Date:   Wed Dec 13 23:58:45 2023 +0000

    fix: OSC control of client Pause/Resume does not function CasparCG#304

commit c79c5ff
Author: Julian Waller <[email protected]>
Date:   Wed Dec 13 23:55:55 2023 +0000

    fix: GPO saved rising/falling configuration does not correctly recall settings at startup CasparCG#305

commit df81415
Author: Julian Waller <[email protected]>
Date:   Wed Dec 13 23:06:15 2023 +0000

    feat: qt6 and update build tooling CasparCG#307

commit 5b5743a
Author: Julian Waller <[email protected]>
Date:   Wed Dec 13 23:21:42 2023 +0000

    wip: delete committed libraries and binaries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants