Compare _snapshotInfo in Version

[artoonie]

According to semver, 1.0.0-alpha < 1.0.0-beta.

However, Version.compareTo does not account for _snapshotInfo in its comparison: https://github.com/FasterXML/jackson-core/blob/2.16/src/main/java/com/fasterxml/jackson/core/Version.java#L135

Does it make sense to compare _snapshotInfo as well?

[HEdingfield]

An easy way to get the desired behavior here would probably be to sort the stuff after the hyphen alphabetically, and whichever is earlier in the list would be considered "older".

[cowtowncoder]

To be honest, comparability is not used by anything in Jackson itself so it's not a big deal in that sense.

But if anyone wants to fix this, feel free to send a PR; ideally because it solves an actual problem (code outside of Jackson relying on ordering of snaphot info).

[artoonie]

This would fix a problem for us. I have created two PRs based on whether you prefer this in 2.16 or master. I recommend closing #1053 and merging #1054.

[cowtowncoder]

@artoonie One question: is the comparison in case of "no snapshot info" correct? It seems to me that it would "no snapshot" before snapshot -- which is not correct, I think. That is: as things are, this would be considered ordering:

 2.0.0 < 2.0.0-SNAPSHOT

which is not right I think. I'll see if this is the case or not.

EDIT: I thing I was wrong; behavior is correct as-is. Same as in master (3.0.0-SNAPSHOT). No changes necessary.
And I think this is same as what Maven uses, although cannot be 100% certain (logic within there is rather complicated). So I think what we have are might be correct.

But I would definitely appreciate others looking into this.

[artoonie]

According to semver.org, 2.0.0 is newer than 2.0.0-beta, which is the implemented behavior (but seems to be the opposite of your comment?).

[cowtowncoder]

@artoonie Ok yes that makes sense. I was confused by implementation (compareTo() semantics is something I always struggle with). So I think we are all good.

[HEdingfield]

Thank you both! Any ETA on when 2.16 will be released?

[cowtowncoder]

Not for quite a while; no ETA. Maybe in August/September?