Retrofit ContentReference with new ErrorReportConfiguration
#1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JooHyukKim
commented
Jul 29, 2023
| @@ -203,10 +249,11 @@ public Object getRawContent() { | |||
| * which content is counted, either bytes or chars) to use for truncation | |||
| * (so as not to include full content for humongous sources or targets) | |||
| * | |||
| * @see ErrorReportConfiguration#builder()#_maxRawContentLength | |||
| * @return Maximum content snippet to include before truncating | |||
| */ | |||
| protected int maxContentSnippetLength() { | |||
There was a problem hiding this comment.
wrt method name, I think we need method named maxRawContentLength() to return _maxRawContentLength, not maxContentSnippetLength.
Since the method is protected., we can think of two options do with its name.
- Direclty change name. Since it is "Internal" accessor as mentioned in JavaDoc, shouldn't be used outside class
Suggested change
| protected int maxContentSnippetLength() { | |
| protected int maxRawContentLength() { |
- Since method is
protected, take two steps. Deprecate originalmaxContentSnippetLength()and create newmaxRawContentLength()
There was a problem hiding this comment.
Let's go with straight change since it is internal (option (1)). I feel confident this won't break usage by others, given it is reasonable recently added internal method.
cowtowncoder
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #1066
(blocked by #1068)