Further work on #1385: try moving test classes to different package #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowtowncoder
commented
Jan 13, 2025
| final static int MAX_CHAR_BUFFER_SIZE = 32000; // use segments beyond | ||
| final static int MIN_BYTE_BUFFER_SIZE = 24; | ||
| final static int MAX_BYTE_BUFFER_SIZE = 32000; // use segments beyond | ||
| public final static int MIN_CHAR_BUFFER_SIZE = 16; |
There was a problem hiding this comment.
Not ideal, but none of visibility increases should be problematic per se.
Should minimize testing based on of such constants of course but first things first.
|
Ok: things work at this end so let's go ahead and see if we can make |
|
@JooHyukKim This is a big refactoring: due to module (JPMS) limitations, need to basically move test classes under different Java package ( Note that this change is only needed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this is required to properly separate jackson-core packages (actual streaming package) and test support classes published/exported for other components' tests to use.
(no package splitting with JPMS)