Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #968: prevent some conversion from BigInteger to BigDecimal for perf reasons #980

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Fix #968: prevent some conversion from BigInteger to BigDecimal for perf reasons #980

merged 2 commits into from
Apr 6, 2023

Conversation

cowtowncoder
Copy link
Member

No description provided.

@cowtowncoder
Copy link
Member Author

@pjfanning Was first thinking of more complex set up to derive limit from _maxNumLen (to allow loosening by users) but then figure that simpler is better. I am not sure I see a common case where this limit would become truly problematic.
And it does block problematic case.

@cowtowncoder cowtowncoder mentioned this pull request Apr 5, 2023
Closed
@cowtowncoder
Copy link
Member Author

@pjfanning Any concerns?

@pjfanning
Copy link
Member

seems fine to me

@cowtowncoder cowtowncoder merged commit ccf668b into 2.15 Apr 6, 2023
@cowtowncoder cowtowncoder deleted the tatu/968-limit-big-integer-scale branch April 6, 2023 19:59
@cowtowncoder cowtowncoder added this to the 2.15.0-rc3 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjfanning pjfanning pjfanning left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.15.0-rc3
Development

Successfully merging this pull request may close these issues.
2 participants
@cowtowncoder @pjfanning