Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sh_string implementation breaks on Android 5 Lollipop (ksh) #715

Closed
zachriggle opened this issue Sep 1, 2016 · 1 comment
Closed
Labels
Milestone

Comments

@zachriggle
Copy link
Member

zachriggle commented Sep 1, 2016

Unfortunately, printf is not universal. It is missing from the toolbox implementation of ksh.

root@generic:/ # echo hello
hello
root@generic:/ # echo -e "h\x65llo"
hello
root@generic:/ # printf hello
/system/bin/sh: printf: not found

It seems that a non-universal solution is needed for this.

Linux is easy.

The BSDs make it hard, but we can detect those scenarios with context.os='freebsd' or similar.

Android will require active detection of the current device and its capabilities.

The implementation was changed in 72207cf. It's not clear whether it ever worked on Android, but the current implementation definitely does not.

@zachriggle zachriggle added the bug label Sep 1, 2016
@zachriggle zachriggle added this to the Someday milestone Sep 1, 2016
@zachriggle
Copy link
Member Author

This is now fixed via #717. The specific use of echo is broken, because echo is broken.

@zachriggle zachriggle modified the milestones: Someday, 3.2.0 Sep 11, 2016
Kyle-Kyle pushed a commit to Kyle-Kyle/pwntools that referenced this issue Apr 25, 2021
* Feature: show ghidra decompiled code in context

With the help of radare2, r2pipe and r2ghidra-dec

* Update FEATURES.md

* Include review comments

* Removed embarrassing auto added guards

Co-authored-by: Disconnect3d <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant