Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding non-default gdb handling #1074

Merged
merged 1 commit into from
Dec 7, 2017
Merged

Conversation

bannsec
Copy link
Contributor

@bannsec bannsec commented Nov 30, 2017

Ref #1071 -- this minor change allows users to override the default gdb front-end with something else. I have tested it with a simple python wrapper that instead connects up with radare2. Works pretty slick.

@zachriggle
Copy link
Member

zachriggle commented Dec 7, 2017

Would you mind rebasing this? We had some issues with the tests on dev. Could you also add Fixes Gallopsled/pwntools#1071 to the end of the commit message? Thanks!

Git Tip

In case you're not familiar with git rebase and changing commit messages git commit --amend:

# Check out the branch with your work
$ git checkout non-gdb

# Get a copy of the updated pwntools dev branch, and re-play your changes 
# instead of merging them with '--rebase'
$ git pull --rebase https://github.com/Gallopsled/pwntools dev

# Update your commit message
$ git commit --amend

# Push your updated 'non-gdb' branch to Github, using '--force' to overwrite the old branch
$ git push --force https://github.com/bannsec/pwntools non-gdb

@zachriggle
Copy link
Member

Actually, nevermind, I think all of that can be ignored and I can do it trivially from the Github UI.

@zachriggle zachriggle merged commit c3afdd6 into Gallopsled:dev Dec 7, 2017
@zachriggle zachriggle added this to the 3.12.0 milestone Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants