Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validation of log level name for Python 3 #1939

Merged
merged 3 commits into from
Jul 29, 2021
Merged

Fix validation of log level name for Python 3 #1939

merged 3 commits into from
Jul 29, 2021

Conversation

clubby789
Copy link
Contributor

Closes #1938

Arusekk
Arusekk requested changes Jul 28, 2021
View reviewed changes
Copy link
Member

@Arusekk Arusekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ! So sad we have not noticed it so far.

@Arusekk
Copy link
Member

Arusekk commented Jul 28, 2021

Also, maybe instead of a version check, you could do a try: (py3 code) except AttributeError: (py2 code)?

@Arusekk Arusekk merged commit 11b8537 into Gallopsled:dev Jul 29, 2021
gogo2464 pushed a commit to gogo2464/pwntools that referenced this pull request Sep 10, 2023
@clubby789
Fix validation of log level name for Python 3 (Gallopsled#1939)
d114351 
* Fix validation of log level name for Python 3

* Add changelog

* Reorder changelog and use try/except
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arusekk Arusekk Arusekk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error while setting log level
2 participants
@clubby789 @Arusekk