Use a more reliable way to split the KDE konsole #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can probably get away with offloading the XML parsing to $ qdbus $KONSOLE_DBUS_SERVICE
/
/KBookmarkManager
/KBookmarkManager/konsole
/MainApplication
/Sessions
/Sessions/1
/Windows
/Windows/1
/konsole
/konsole/MainWindow_1
/konsole/MainWindow_1/actions
/konsole/MainWindow_1/actions/open_kcommand_bar
/konsole/MainWindow_1/actions/bookmark
/konsole/MainWindow_1/actions/options_show_menubar
/konsole/MainWindow_1/actions/fullscreen
/konsole/MainWindow_1/actions/options_configure_notifications
/konsole/MainWindow_1/actions/options_configure_keybinding
/konsole/MainWindow_1/actions/options_configure
/konsole/MainWindow_1/actions/options_configure_keybinding
/konsole/MainWindow_1/actions/options_configure_toolbars
/org
/org/kde
/org/kde/konsoleNot sure whether it is strictly better, but since we already use an external process for D-Bus calls, I think we can leverage its abilities. |
|
The changelog needs two lines added, if you decide to update it. |
|
Oh, right |
gogo2464
pushed a commit
to gogo2464/pwntools
that referenced
this pull request
Sep 10, 2023
* Use a more reliable way to split the KDE konsole * Changed xml parsing to pure parsing * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more stable way to split KDE Konsole than in #2023.
Problems can start only after detaching the tab of KDE Konsole (the
$WINDOWIDenvironment variable remains in the detached tab), but otherwise the code works well.