-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow libcdb search offline database #2259
Closed
Closed
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
ce348a4
Allow libcdb search offline database
the-soloist 28e5c73
Rename PROVIDERS function
the-soloist 541398c
Update global parameter retrieval method for libcdb
the-soloist 20b6cd6
Add 'raw' parameter to libcdb
the-soloist 1236b82
Add 'local_libcdb' member to Context class
the-soloist 6f80685
Implement automatic 'offline' parameter modification
the-soloist 966ce41
Enable cache support for offline mode in libcdb.
the-soloist 4c705a1
Rearrange the order of online providers
the-soloist 1fad910
Reorder 'raw' parameter return position
the-soloist d9d1706
Add a hook for local_libcdb
the-soloist 1507d79
Modify the default value of local_libcdb
the-soloist efe7908
Enhance libcdb search logic
the-soloist 2edbf33
Modify the default value of context.local_libcdb
the-soloist 6181a9a
Delete unused argument
the-soloist 86ca7e3
Add pure offline mode
the-soloist a0d4ae4
Adapt to the changes made in libcdb.py
the-soloist f99c44a
Add a download feature to the libcdb cli
the-soloist 2d71793
Fix continuous integration test 2.7
the-soloist 4064f42
Reduce redundant search
the-soloist d3fb137
Fix examples
the-soloist ec3fc6d
test
the-soloist File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attempting to unstrip the libc should be enabled by default, so this can be cleaned up the other way around to only keep the
--no-unstrip
but default toTrue
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okey, but I believe it would be better to set the default value of
--no-unstrip
toFalse
. This way, I can passnot args.no_unstrip
as the value forunstrip
.In the following code, by default,
unstrip
isTrue
. If we use the--no-unstrip
, theunstrip
parameter will becomeFalse
.