-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add local libc database provider for libcdb #2356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for starting to split #2259 up into manageable chunks! I really wanted to have it in 4.13.0 but didn't have the time to fix it up properly. I've left some comments inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for documenting this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I assume you'll use that libc and symbols in a future PR? We could just set the test dir to any valid folder, since it's not used I think. It might influence other tests, but only if we'd lookup the one libc that's in there.
All that's left is an entry in the changelog file :) |
I will use them in future PRs, but I'm uncertain whether the test cases need modifications. I think I should remove them for now. |
Add local libc database provider for libcdb and a property
context.local_libcdb
onContextType
.