Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local libc database provider for libcdb #2356

Merged
merged 10 commits into from
Mar 1, 2024

Conversation

the-soloist
Copy link
Contributor

Add local libc database provider for libcdb and a property context.local_libcdb on ContextType.

Copy link
Member

@peace-maker peace-maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for starting to split #2259 up into manageable chunks! I really wanted to have it in 4.13.0 but didn't have the time to fix it up properly. I've left some comments inline.

Copy link
Member

@peace-maker peace-maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for documenting this!

Copy link
Member

@peace-maker peace-maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I assume you'll use that libc and symbols in a future PR? We could just set the test dir to any valid folder, since it's not used I think. It might influence other tests, but only if we'd lookup the one libc that's in there.

@peace-maker
Copy link
Member

All that's left is an entry in the changelog file :)

@the-soloist
Copy link
Contributor Author

I will use them in future PRs, but I'm uncertain whether the test cases need modifications. I think I should remove them for now.

@peace-maker peace-maker merged commit 3b4b261 into Gallopsled:dev Mar 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants