Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up OnSystem rbis #19306

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Clean up OnSystem rbis #19306

merged 1 commit into from
Feb 14, 2025

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Feb 14, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

These definitions should be within the module that defines them, not the modules that include them. (I've also removed the unneeded utils/gems.rbi file.)

@dduugg dduugg added this pull request to the merge queue Feb 14, 2025
Merged via the queue into master with commit 673f190 Feb 14, 2025
30 checks passed
@dduugg dduugg deleted the on-system-rbis branch February 14, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants