notcurses 2.3.12 (new formula)

[dankamongmen]

• Have you followed the guidelines for contributing?
  -Yes, including the line

  We frown on authors submitting their own work unless it is very popular.

  I asked for a clarification regarding this at how popular is "very popular"? discussions#1893, and believe it not to be an issue.

• Have you ensured that your commits follow the commit style guide?

• Have you checked that there aren't other open pull requests for the same formula update/change?

• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?

• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  -Yes, but I had to do two gross things. I export a TERM of xterm, as otherwise there is no TERM. I ought be pulling in TERM from the environment, where it ought always be set. Two, I redirect stdout (not stderr) to /dev/null, as otherwise the test process blows up (notcurses-tester generates a lot of output).

• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?
  -No. I get the output Dependency 'ncurses' is provided by macOS; please replace 'depends_on' with 'uses_from_macos'. I want ncurses from homebrew, though. Is this the incorrect way to specify that? I'm using uses_from_macos for zlib, as you can see.

---

[dankamongmen]

The CI seems to be complaining about the ncurses bit as well, but I definitely want the one from Homebrew. The macOS version is too old. The vim.rb formula seems to depend on "ncurses" just fine...

[dankamongmen]

still unsure what to do about this

==> Installing 'bundler' gem
notcurses:
  * Dependency 'ncurses' is provided by macOS; please replace 'depends_on' with 'uses_from_macos'.
Error: 1 problem in 1 formula detected
==> brew bottle --verbose --json notcurses --only-json-tab
==> brew bottle --merge --write --no-commit ./notcurses--2.3.12.arm64_big_sur.bottle.json
==> brew uninstall --force notcurses
==> brew uninstall --force asciidoc asciidoctor autoconf autoconf-archive automake bison boost cabal-install cargo-c cmake docbook docbook-xsl doctest doxygen ghc gnu-getopt gnu-sed libatomic_ops libgit2 libssh2 llvm meson nasm ninja pandoc rust source-highlight sphinx-doc swig util-macros xcb-proto xmlto xtrans yasm
==> brew install --only-dependencies ./notcurses--2.3.12.arm64_big_sur.bottle.tar.gz
==> brew install ./notcurses--2.3.12.arm64_big_sur.bottle.tar.gz
==> brew linkage --test notcurses
==> brew install --only-dependencies --include-test notcurses
==> brew test --verbose notcurses
==> FAILED
==> Testing notcurses
/usr/bin/sandbox-exec -f /private/tmp/homebrew20210729-77855-1u4t9hr.sb ruby -W1 -- /opt/homebrew/Library/Homebrew/test.rb /opt/homebrew/Library/Taps/homebrew/homebrew-core/Formula/notcurses.rb --verbose
==> /opt/homebrew/Cellar/notcurses/2.3.12/bin/notcurses-info
Error: test failed
dyld: Library not loaded: @rpath/libnotcurses.2.dylib
  Referenced from: /opt/homebrew/Cellar/notcurses/2.3.12/bin/notcurses-info
  Reason: image not found
Error: notcurses: failed

is the "image not found" related to the early failure? and how do i work around this to require the Brew of ncurses? i seem to be doing the same thing as the vim package.

[SMillerDev]

It fails to load it's own library from the rpath. It's unrelated to the ncurses audit above.

[carlocab]

LGTM, provided the only failure remaining is the audit failure.

Thanks for your contribution to Homebrew, @dankamongmen.

[carlocab]

Oops, Linux will fail as we haven't bottled ffmpeg yet. We can ignore that.

[dankamongmen]

LGTM, provided the only failure remaining is the audit failure.

Thanks for your contribution to Homebrew, @dankamongmen.

no, thank you for the opportunity and feedback, and for making open source available to macOS users!

i will diligently maintain this Formula as i do all my other packages elsewhere.

[carlocab]

Great. You probably won't need to do much as long as you don't change your build system or your dependencies. For version bumps, you might be interested in brew bump-formula-pr, or https://github.com/dawidd6/action-homebrew-bump-formula.

[BrewTestBot]

@carlocab has triggered a merge.