Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add precompile statements #10

Merged
merged 2 commits into from
Sep 7, 2022
Merged

add precompile statements #10

merged 2 commits into from
Sep 7, 2022

Conversation

t-bltg
Copy link
Member

@t-bltg t-bltg commented Sep 7, 2022

Using SnoopPrecompile, results on 1.8.1.

before

julia> @time_imports using MarchingCubes
      0.3 ms  SnoopPrecompile
      3.4 ms  StaticArraysCore
    892.3 ms  StaticArrays
      1.2 ms  MarchingCubes

julia> @time mc = MarchingCubes.scenario(4, 4, 4; F = Float64, I = Int);
  0.068600 seconds (4.15 k allocations: 187.344 KiB, 99.94% compilation time)

julia> @time march(mc)
  2.529913 seconds (3.61 M allocations: 183.588 MiB, 11.35% gc time, 99.90% compilation time)

pr

julia> @time_imports using MarchingCubes
      0.3 ms  SnoopPrecompile
      3.6 ms  StaticArraysCore
    951.1 ms  StaticArrays
    156.1 ms  MarchingCubes

julia> @time mc = MarchingCubes.scenario(4, 4, 4; F = Float64, I = Int);
  0.066706 seconds (4.15 k allocations: 187.016 KiB, 99.93% compilation time)

julia> @time march(mc)
  1.146681 seconds (91.12 k allocations: 3.361 MiB, 100.00% compilation time)

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #10 (5c29c05) into main (fa3e135) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files           2        2           
  Lines         440      445    +5     
=======================================
+ Hits          439      444    +5     
  Misses          1        1           
Impacted Files Coverage Δ
src/MarchingCubes.jl 99.75% <ø> (ø)
src/example.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@t-bltg t-bltg added the ttfx label Sep 7, 2022
@t-bltg t-bltg merged commit 219e430 into JuliaGeometry:main Sep 7, 2022
@t-bltg t-bltg deleted the precomp branch September 7, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant