Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a brief demonstration for visualization with Makie #8

Merged
merged 14 commits into from
May 20, 2022

Conversation

Ickaser
Copy link
Contributor

@Ickaser Ickaser commented May 20, 2022

As we discussed in #7 , here is a MWE demonstrating how to make a Meshes.jl mesh from this mesh structure, so it can be visualized with GLMakie. I am happy to move this to a separate file or elsewhere in the README, and can include an image of the output as well.

Fixes #7.

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #8 (4e2c667) into main (93e5581) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files           2        2           
  Lines         436      440    +4     
=======================================
+ Hits          435      439    +4     
  Misses          1        1           
Impacted Files Coverage Δ
src/example.jl 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@t-bltg
Copy link
Member

t-bltg commented May 20, 2022

Very nice, thanks. I'll be able to try this in about an hour. I've been able to reproduce this.

can include an image of the output as well.

Good idea. For the inclusion of an example img, you can make a separate PR to the marchingcubes-docs branch and link to it in README.md, as I did for the current paraview image.

EDIT: image PR created in #9.

@t-bltg t-bltg merged commit ae68a82 into JuliaGeometry:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: make mesh more amenable to other Julia datatypes?
2 participants