-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
julia 0.6 broadcast integration #327
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17aa9da
to
3444ef5
Compare
current patch set: julia> @benchmark log.(2, $cl .+ 1)
BenchmarkTools.Trial:
memory estimate: 41.47 KiB
allocs estimate: 1251
--------------
minimum time: 93.868 μs (0.00% GC)
median time: 96.204 μs (0.00% GC)
mean time: 100.758 μs (3.53% GC)
maximum time: 2.244 ms (92.37% GC)
--------------
samples: 10000
evals/sample: 1
shell> git log | head
commit da49c48a78f633d5e56c3659d38bde1132212926
Author: Iblis Lin <iblis@hs.ntnu.edu.tw>
Date: Sun Sep 3 19:19:13 2017 +0800
broadcast: wip: rewrite broadcast_c in generated func |
I think it's ready for review |
Bump? |
like overlaps, the var args version
In Base.Broadcast, broadcast promote the types first via _containertype and promote_containertype. The dispatch to broadcast_c with second parameter indicating the promoted type.
I'm going to merge this PR tmr, if no objection |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is derived from #321 (comment)
This PR make generic function do
broadcast
call correctly.e.g.
Performance
The performance of current implementation is quite poor and the memory requirement is larger :(.
(I'm going to read more about performance tips. Please advise)
A test case for
log.(2, cl .+ 1)
which the works fine before.Before:
After:
TODO