-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace find -> findall and fix issue 432 #433
Conversation
The function find is not defined and caused an UndefVarError when this line was executed.
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
+ Coverage 85.89% 87.25% +1.36%
==========================================
Files 11 11
Lines 475 510 +35
==========================================
+ Hits 408 445 +37
+ Misses 67 65 -2
Continue to review full report at Codecov.
|
Hi @Sh4pe could you test the updated patches? |
It still does not work and fails inside
(The Julia 1.0 build job failed because it could not connect to GitHub. Maybe it needs to be rekicked). |
ah, I fixed the error message. using MarketData
TimeSeries.Candlestick(ohlcv) |
Ok, got it. I like the solution - no more comments 😄 |
Thanks for your contribution. I'm going to make a new release. |
The function find is not defined and caused an UndefVarError
when this line was executed.
Fixes #432