Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DXF as an exportable 2D format #762

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alteous
Copy link
Contributor

@alteous alteous commented Feb 17, 2025

There is no corresponding import 2D format yet. This is intended only as an export format from the engine. Conversions to/from DXF are not supported yet.

@alteous
Copy link
Contributor Author

alteous commented Feb 17, 2025

Ideally OutputFormat would be renamed as OutputFormat3d but that would break everything. Perhaps we could add an alias for compatibility?

@alteous alteous requested a review from adamchalmers February 17, 2025 14:50
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 55 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@eda2f19). Learn more about missing BASE report.

Files with missing lines Patch % Lines
modeling-cmds/src/format/mod.rs 0.00% 40 Missing ⚠️
modeling-cmds/src/convert_client_crate.rs 0.00% 8 Missing ⚠️
modeling-cmds/src/format/dxf.rs 0.00% 3 Missing ⚠️
modeling-cmds/src/def_enum.rs 0.00% 2 Missing ⚠️
modeling-cmds/src/shared.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #762   +/-   ##
=======================================
  Coverage        ?   24.91%           
=======================================
  Files           ?       36           
  Lines           ?     2131           
  Branches        ?        0           
=======================================
  Hits            ?      531           
  Misses          ?     1600           
  Partials        ?        0           
Flag Coverage Δ
unittests 24.91% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

There is no corresponding import 2D format yet. This is intended only as an
export format from the engine. Conversions to/from DXF are not supported yet.
@alteous alteous marked this pull request as ready for review February 21, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants