-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backspace should not remove geometry #5007
Comments
Thanks reporting this @DylanBryant. I'll mark it as Bug first as I think either way no deletion should be attempted in this case and we should guard for that. Then we can talk about separating backspace and delete on non-mac platforms yes that's also a good point |
Okay I don't think that the command palette should dismiss when the user hits Backspace or Delete. We have it "step back" in the command palette from an argument (like the prompt argument in the video), but I don't think it should go all the way out of the command palette use state; that should be reserved to explicit dismssal with Escape. Then this state won't be reachable. |
It leads to awkward UX like the one reported in #5007. Users can still go back between arguments using <kbd>Backspace</kbd> on an empty argument, but to close it they have to hit <kbd>Escape</kbd>, <kbd>Cmd+K</kbd>, or click the close button.
* Don't close the command palette on backspace It leads to awkward UX like the one reported in #5007. Users can still go back between arguments using <kbd>Backspace</kbd> on an empty argument, but to close it they have to hit <kbd>Escape</kbd>, <kbd>Cmd+K</kbd>, or click the close button. * fmt '
was this fixed, i notice there was no regression test for it so ill leave the issue open and add a label |
@jessfraz @franknoirot on top of that the other part of this issue is that backspace on windows (and likely linux) shouldn't be used for delete cause there is a real delete key there (compared to macOS that merges some of the deletion patterns into backspace that is called delete). See modeling-app/src/components/ModelingMachineProvider.tsx Lines 1725 to 1726 in 5232e1d
|
Backspace.in.dialogue.boxes.mp4
- One area where this is a problem: When creating 3D geometry or using the Prompt-to-edit features, if you hold backspace to remove the text, it does not stop within the dialogue box and continues to delete the geometry.
The text was updated successfully, but these errors were encountered: