-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default planes to std #5433
base: main
Are you sure you want to change the base?
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5433 +/- ##
==========================================
- Coverage 86.02% 85.86% -0.17%
==========================================
Files 95 95
Lines 35754 36076 +322
==========================================
+ Hits 30757 30975 +218
- Misses 4997 5101 +104
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Nick Cameron <[email protected]>
Signed-off-by: Nick Cameron <[email protected]>
Signed-off-by: Nick Cameron <[email protected]>
This removes the need for magic strings for default planes, although that probably needs a little more testing before I'd recommend it as the default.
In order to add the planes to std I needed to support type ascription for coercing a struct to a plane and negation for planes (to support
-XZ
, etc.). Although I don't restrict it's use, I wouldn't recommend documenting or recommending type ascription for users.Internally, I add the concept of an uninitialised plane, which is one which has not been sent to the engine yet.