Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default planes to std #5433

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add default planes to std #5433

wants to merge 3 commits into from

Conversation

nrc
Copy link
Contributor

@nrc nrc commented Feb 20, 2025

This removes the need for magic strings for default planes, although that probably needs a little more testing before I'd recommend it as the default.

In order to add the planes to std I needed to support type ascription for coercing a struct to a plane and negation for planes (to support -XZ, etc.). Although I don't restrict it's use, I wouldn't recommend documenting or recommending type ascription for users.

Internally, I add the concept of an uninitialised plane, which is one which has not been sent to the engine yet.

@nrc nrc requested a review from jtran February 20, 2025 07:13
Copy link

qa-wolf bot commented Feb 20, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 22, 2025 7:30am

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 73.39056% with 124 lines in your changes missing coverage. Please review.

Project coverage is 85.86%. Comparing base (3ddce11) to head (6ab1682).

Files with missing lines Patch % Lines
src/wasm-lib/kcl/src/execution/kcl_value.rs 39.18% 45 Missing ⚠️
src/wasm-lib/kcl/src/parsing/ast/types/mod.rs 70.64% 32 Missing ⚠️
src/wasm-lib/kcl/src/execution/geometry.rs 62.50% 18 Missing ⚠️
src/wasm-lib/kcl/src/execution/exec_ast.rs 92.59% 10 Missing ⚠️
src/wasm-lib/kcl/src/parsing/ast/digest.rs 0.00% 4 Missing ⚠️
src/wasm-lib/kcl/src/std/args.rs 50.00% 4 Missing ⚠️
src/wasm-lib/kcl/src/walk/ast_node.rs 0.00% 4 Missing ⚠️
src/wasm-lib/kcl/src/execution/mod.rs 86.95% 3 Missing ⚠️
src/wasm-lib/kcl/src/walk/ast_visitor.rs 0.00% 2 Missing ⚠️
src/wasm-lib/kcl/src/parsing/parser.rs 96.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5433      +/-   ##
==========================================
- Coverage   86.02%   85.86%   -0.17%     
==========================================
  Files          95       95              
  Lines       35754    36076     +322     
==========================================
+ Hits        30757    30975     +218     
- Misses       4997     5101     +104     
Flag Coverage Δ
wasm-lib 85.86% <73.39%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nrc added 3 commits February 22, 2025 20:18
Signed-off-by: Nick Cameron <[email protected]>
Signed-off-by: Nick Cameron <[email protected]>
Signed-off-by: Nick Cameron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant